Tracking Issue: Fix auto-applicable lint suggestions by using multipart suggestions

[flip1995]

Description

#13098 introduced @no-rustfix annotations, that can be removed by changing the suggestion to a multipart suggestion:

//@no-rustfix: need to change the suggestion to a multipart suggestion

The affected test files are:

• ui-toml/max_suggested_slice_pattern_length/index_refutable_slice.rs
• ui/crashes/ice-3717.rs
• ui/derivable_impls.rs
• ui/index_refutable_slice/if_let_slice_binding.rs
• ui/index_refutable_slice/slice_indexing_in_macro.rs
• ui/let_unit.rs
• ui/manual_assert.rs
• ui/manual_async_fn.rs
• ui/manual_split_once.rs
• ui/match_same_arms2.rs
• ui/significant_drop_tightening.rs
• ui/unnecessary_iter_cloned.rs
• ui/unnecessary_to_owned.rs

To fix some of those:

1. Pick one test and leave a comment about it
2. Remove the @no-rustfix annotation
3. Change the lint suggestion building to use multipart_suggestion over the current implementation
4. write a comment here or mention this issue in the PR so that it gets marked as resolved.

Version

No response

Additional Labels

No response

[ibilalkayy]

Hey @flip1995, I just sent a PR to solve a problem that you mentioned in this issue. Thank you!

[flip1995]

Copying a comment by @kyoto7250, that explains the tasks here a bit better than I have in the issue: #13216 (comment)

I [kyoto7250] have created a PR that fixes one of the files in this issue. #13230

In PR #13098, all tests that were expected to split into multipart files have been deleted and set to be skipped using @no-rustfix. Therefore, simply removing the annotation is not sufficient.

You remove @no-rustfix and run cargo uitest locally, the tests should fail. For more details, please refer to the following documentation:

https://github.com/rust-lang/rust-clippy/blob/master/book/src/development/writing_tests.md

In my PR, multiple files were not generated, but I believe that in this issue, it is expected that multiple files will be generated by the multipart suggestion.

[scottgerring]

I pushed a change to address this for ui/derivable_impls.rs - if it looks sane, i'll polish up a few of the others too!

[scottgerring]

I pushed a change for ui-toml/max_suggested_slice_pattern_length/index_refutable_slice.rs above too.