Skip to content

Enhance needless_collect to cover ".join" #16328

@profetia

Description

@profetia

Description

When having an iterator of strings, one might use .collect<Vec<_>>().join(" ") to concat the strings with a given seperator. However, it might be better to use .intersperse then .collect directly, if the intersperse feature is enabled. For example

let v = vec!["123"];
let iter = v.into_iter();
iter.collect::<Vec<_>>().join(",");

Use instead:

let v = vec!["123"];
let iter = v.into_iter();
iter.intersperse(",").collect::<String>();

Version


Additional Labels

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementCategory: Enhancement of lints, like adding more cases or adding help messages

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions