Skip to content

Conversation

@GnomedDev
Copy link
Contributor

Closes #10.

changelog: [question_mark]: Now lints for match-based manual try

@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 30, 2024
@GnomedDev GnomedDev force-pushed the manual-try branch 2 times, most recently from c33ce3a to 6f27195 Compare October 30, 2024 11:59
@GnomedDev GnomedDev requested a review from y21 November 2, 2024 13:41
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y21 y21 enabled auto-merge November 10, 2024 16:12
@y21
Copy link
Member

y21 commented Nov 10, 2024

Hm right, old PRs need to rerun CI with the switch to the merge queue

@y21 y21 closed this Nov 10, 2024
auto-merge was automatically disabled November 10, 2024 16:15

Pull request was closed

@y21 y21 reopened this Nov 10, 2024
@y21 y21 added this pull request to the merge queue Nov 10, 2024
Merged via the queue into rust-lang:master with commit f58088b Nov 10, 2024
16 checks passed
@GnomedDev GnomedDev deleted the manual-try branch November 10, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

match on Result<T,E> and return the error

4 participants