fix(let_unit_value): create the suggestion "differentially" #15788
+152
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
rustbot has assigned @samueltardieu. Use |
|
Lintcheck changes for f6dd112
This comment will be updated if you push new changes |
samueltardieu
approved these changes
Sep 29, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e, instead of constructing a whole new
LetStmtto replace the old one, suggest to only change the part of theLetStmtthat we don't like. This makes the suggestion less likely to introduce spurious changes, but also makes the diagnostic much nicer imo.Fixes #15771 by not adding a semicolon that the initial
LetStmtdidn't haveFixes #15784 by using the
init.spanwith the correctSyntaxContextchangelog: [
let_unit_value]: don't add spurious semicolonchangelog: [
let_unit_value]: don't mangle macro calls