Skip to content

manual_unwrap_or: fix FP edge case #15812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

manual_unwrap_or: fix FP edge case #15812

wants to merge 2 commits into from
+27 −7

Conversation

notriddle
Copy link
Contributor

changelog: [manual_unwrap_or]: fix FP edge case

Found this problem while investigating a different bug.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 3, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@notriddle notriddle force-pushed the manual-unwrap-or-edge-case branch from 62c323b to 6d713ce Compare October 3, 2025 18:33
blyxyas
blyxyas requested changes Oct 3, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great patch! Just some nits

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 3, 2025
@notriddle
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Oct 4, 2025
@notriddle @blyxyas
Fix style nits
81dde98 
Co-authored-by: Alejandra González <[email protected]>
@notriddle notriddle force-pushed the manual-unwrap-or-edge-case branch from 735950c to 81dde98 Compare October 4, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notriddle @rustbot @blyxyas