feat(zero_repeat_side_effects): don't suggest unnecessary braces around stmts #15826
+85
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
?? triagebot is doing weird things |
|
No no, that's on me, sorry for the confusion^^ Samuel had asked me to assign him to this PR, but I forgot to do that when opening the PR, and so triagebot picked you as the random assignee |
|
|
||
| // when singled out/not part of assignment/local | ||
| { f(); vec![] as std::vec::Vec<i32> }; | ||
| f(); vec![] as std::vec::Vec<i32>; |
There was a problem hiding this comment.
Nit: can't you put this on two lines and repeat the indentation? It would probably look cleaner.
There was a problem hiding this comment.
You're right, I just got lazy... Went ahead and added the indentation to all the other variants while at it
ada4a
force-pushed
the
zero_repeat_side_effects-3
branch
from
d93aa82 to
dfc1ae8
Compare
ada4a
force-pushed
the
zero_repeat_side_effects-3
branch
from
dfc1ae8 to
bb53f99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
(zero_repeat_side_effects]: don't suggest unnecessary braces around stmtsr? @samueltardieu