feat(format_push_string): give a (possibly incomplete) suggestion #16093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Collaborator
|
rustbot has assigned @samueltardieu. Use |
ada4a
force-pushed
the
format_push_string-simple
branch
from
278b57f to
5ea08dd
Compare
|
Lintcheck changes for 5ea08dd
This comment will be updated if you push new changes |
samueltardieu
requested changes
Nov 18, 2025
Comment on lines
+160
to
+162
| // TODO: Ideally we'd use `TyCtxt::in_scope_traits` to detect whether the trait is imported, and | ||
| // either not emit this note if it is, or emit an automated suggestion to import it if it isn't. | ||
| // But the method doesn't seem to work, see https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/How+to+suggest+importing+a+path/with/544260181 |
Member
There was a problem hiding this comment.
I wouldn't say that the method doesn't seem to work if you call it outside of its intended use. Given its lack of documentation, it is hard to say. If you want to investigate, you might be luckier asking in a compiler-related Zulip channel.
Suggested change
| // TODO: Ideally we'd use `TyCtxt::in_scope_traits` to detect whether the trait is imported, and | |
| // either not emit this note if it is, or emit an automated suggestion to import it if it isn't. | |
| // But the method doesn't seem to work, see https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/How+to+suggest+importing+a+path/with/544260181 | |
| // TODO: omit the note if the `Write` trait is imported at point |
| // TODO: Ideally we'd use `TyCtxt::in_scope_traits` to detect whether the trait is imported, and | ||
| // either not emit this note if it is, or emit an automated suggestion to import it if it isn't. | ||
| // But the method doesn't seem to work, see https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/How+to+suggest+importing+a+path/with/544260181 | ||
| diag.note(format!("you may need to import `{std_or_core}::fmt::Write`")); |
Member
There was a problem hiding this comment.
Suggested change
| diag.note(format!("you may need to import `{std_or_core}::fmt::Write`")); | |
| diag.note(format!("you may need to import the `{std_or_core}::fmt::Write` trait")); |
Comment on lines
+138
to
+141
| let Some(std_or_core) = std_or_core(cx) else { | ||
| // This can't really happen, as a no-core crate wouldn't have access to `String` in the first place | ||
| return; | ||
| }; |
Member
There was a problem hiding this comment.
This might happen though:
Example:
#![feature(no_core)]
#![no_core]
#![no_std]
extern crate std as mystd;
use mystd::convert::From as _;
fn main() {
let mut s = mystd::string::String::from("no core, no std");
s.push_str(&mystd::format!("{}", 1+2));
mystd::println!("s = {s}");
}
Suggested change
| let Some(std_or_core) = std_or_core(cx) else { | |
| // This can't really happen, as a no-core crate wouldn't have access to `String` in the first place | |
| return; | |
| }; | |
| let Some(std_or_core) = std_or_core(cx) else { | |
| return; | |
| }; |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8824
Supersedes #15828 -- I wasn't able to get
TyCtxt::in_scope_traitsto work, so here's a more basic implementation that just adds a note about the possible need to importstd::fmt::Write.changelog: [
format_push_string]: add a suggestion