Skip to content

Fixes #16109: For non-sized types, use reborrow in suggestions to remove while-let loops #16100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #16109: For non-sized types, use reborrow in suggestions to remove while-let loops #16100

wants to merge 1 commit into from
+99 −8

Conversation

@sergiogiro
Copy link

@sergiogiro sergiogiro commented Nov 16, 2025 •
edited
Loading

Fixes #16019 by reborrowing, instead of using by_ref, when the iterator expression is not Sized.

changelog: [`while_let_on_iterator`]: fixes broken suggestion by using reborrow instead of `by_ref` for references to traits that are not `Sized`

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@sergiogiro sergiogiro mentioned this pull request Nov 16, 2025
Open
@github-actions
Copy link

github-actions bot commented Nov 16, 2025 •
edited
Loading

No changes for f4496bf

@Jarcho
Copy link
Contributor

Jarcho commented Nov 17, 2025

The suggestion used to be to borrow/reborrow before it was changed to by_ref. The only change that needs to happen is a check if the iterator expression has a type of &mut ?Sized. The can be done by checking the type's kind for a reference and using Ty::is_sized on the referent type.

@sergiogiro
Copy link
Author

sergiogiro commented Nov 17, 2025

The suggestion used to be to borrow/reborrow before it was changed to by_ref. The only change that needs to happen is a check if the iterator expression has a type of &mut ?Sized. The can be done by checking the type's kind for a reference and using Ty::is_sized on the referent type.

Great, thanks, I can rework the PR to do a reborrow only when needed.

@sergiogiro sergiogiro force-pushed the sergio-clippy/avoid-by-ref-in-suggestion-for-while-replacement branch from 9638f9c to 1c8b099 Compare November 17, 2025 13:13
@sergiogiro sergiogiro force-pushed the sergio-clippy/avoid-by-ref-in-suggestion-for-while-replacement branch from 1c8b099 to f4496bf Compare November 17, 2025 13:19
@sergiogiro
Copy link
Author

sergiogiro commented Nov 17, 2025

Thanks for the advice. Now the PR just changes the behaviour for non-sized types, and adds a couple tests accordingly.

@sergiogiro sergiogiro changed the title Fixes #16109: Avoid by_ref in suggestions to remove while-let loops Fixes #16109: For non-sized types, use reborrow in suggestions to remove while-let loops Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Jarcho Jarcho

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

while_let_on_iterator suggested solution doesn't work in default implementations of traits without explicit Sized bound

3 participants

@sergiogiro @rustbot @Jarcho