Skip to content

Replace some span_lint_and_then calls with span_lint_and_sugg #5484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Replace some span_lint_and_then calls with span_lint_and_sugg #5484

wants to merge 1 commit into from

Conversation

phansch
Copy link
Contributor

@phansch phansch commented Apr 18, 2020

This could probably be linted: It was me essentially checking if span_lint_and_then's closure only contains the call to span_suggestion and ensuring that both spans were the same.

changelog: none

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 18, 2020
@flip1995
Copy link
Member

@xiongmao86 is way ahead of you #5141 😛

I'd rather wait for the completion of #5141 instead of merging this, since that is close to completion.

@phansch
Copy link
Contributor Author

phansch commented Apr 18, 2020

Oh, that's awesome! I'll close this PR then 😆

@phansch phansch closed this Apr 18, 2020
@phansch phansch deleted the then-to-sugg branch April 18, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phansch @flip1995