Add exteranal macros for as_conversions #6317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Thanks for fixing this oversight. @bors r+ |
|
📌 Commit faa3e23 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 21, 2020
Add exteranal macros for as_conversions Added external macros to this PR #4888. r? `@llogiq`
|
💔 Test failed - checks-action_test |
|
Oops, this appears to need a rustup, which should have been introduced in the meantime. Can you rebase? |
|
@bors retry (If no conflicts after a rustup occur, no rebase should be necessary) |
bors
added a commit
that referenced
this pull request
Nov 23, 2020
Add exteranal macros for as_conversions Added external macros to this PR #4888. r? `@llogiq`
|
💔 Test failed - checks-action_test |
|
@bors retry (changelog was missing) |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added external macros to this PR #4888.
r? @llogiq
changelog: none