Fix FP with empty return for needless_return lint
#6549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ebroto (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ThibsG
force-pushed
the
FixClosureNeedlessReturn
branch
from
322f703 to
3975f66
Compare
|
☔ The latest upstream changes (presumably #6586) made this pull request unmergeable. Please resolve the merge conflicts. |
ThibsG
force-pushed
the
FixClosureNeedlessReturn
branch
from
3975f66 to
46aa654
Compare
|
r? @phansch (I'm leaving the team, so I'm reassigning my PRs to other active members) |
|
@bors r+ thanks! |
|
📌 Commit 46aa654 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
Jan 19, 2021
Add test for `needless_return` lint Just a follow up of #6549 that adds a test for this lint. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a false positive in
needless_returnlint, when triggered in a closure usingreturnstatement without value.Fixes: #6501
changelog: none