Skip to content

Commit 731ba70

Browse files
ehussMark-Simulacrum
authored andcommitted
Update for highfive transition
1 parent 3f62755 commit 731ba70

File tree

7 files changed

+16
-12
lines changed

7 files changed

+16
-12
lines changed

src/compiler/membership.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ Being promoted to contributor implies a number of privileges:
6060

6161
It also implies some obligations (in some cases, optional obligations):
6262

63-
- Contributors will be asked if they wish to be added to highfive rotation.
63+
- Contributors will be asked if they wish to be added to the reviewer rotation.
6464
- Contributors are held to a higher standard than ordinary folk when
6565
it comes to the [Code of Conduct][CoC].
6666

src/compiler/reviews.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ reviewed by at least one person who is knowledgeable with the code in
55
question.
66

77
When a PR is opened, you can request a reviewer by including `r?
8-
@username` in the PR description. If you don't do so, the highfive bot
8+
@username` in the PR description. If you don't do so, rustbot
99
will automatically assign someone.
1010

1111
It is common to leave a `r? @username` comment at some later point to

src/infra/service-infrastructure.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ your own work, please let the infrastructure team know.
1919
([bot user account](https://github.com/rust-highfive)) which welcomes newcomers
2020
and assigns reviewers.
2121

22+
> **Note**: Highfive is currently being replaced by [rustbot](#rustbot). This
23+
> service will be shut down in the future once the migration is complete.
24+
2225
## Rust Log Analyzer
2326

2427
The [Rust Log Analyzer](https://github.com/rust-lang/rust-log-analyzer)

src/infra/team-maintenance.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ To make a full team member, the following places need to be modified:
3232
[rust-lang-nursery/TEAM][gh-nursery-team] teams on github must be updated
3333
- the
3434
[internals discussion board has per-team groups](https://internals.rust-lang.org/admin/groups/custom)
35-
- the list of reviewers highfive uses is set in [rust-lang/highfive][highfive]
36-
- the configs are set per-repo; some teams are listed in `rust.json`, whereas
37-
those that span multiple repos are set in `_global.json`
35+
- if the member is going to join the review rotation, they will need to be
36+
added to the `[assign.owners]` section of `triagebot.toml` of the repos
37+
where they will be reviewing
3838

3939
### Team member departure
4040

@@ -45,6 +45,7 @@ Remove the team member from any and all places:
4545
- The [GitHub team][gh-team], [GitHub nursery team][gh-nursery-team]
4646
- [team repo]
4747
- [toolstate notifications]
48+
- `triagebot.toml` files of all repos they were involved in
4849

4950
[gh-team]: https://github.com/orgs/rust-lang/teams
5051
[gh-nursery-team]: https://github.com/orgs/rust-lang-nursery/teams

src/libs/maintaining-std.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ If you spot anything that is outdated, under specified, missing, or just plain i
2020

2121
## If you’re ever unsure…
2222

23-
Maintaining the standard library can feel like a daunting responsibility! Through [`highfive`], the automated reviewer assignment, you’ll find yourself dropped into a lot of new contexts.
23+
Maintaining the standard library can feel like a daunting responsibility! Through automated reviewer assignment via [`triagebot`][assignment], you’ll find yourself dropped into a lot of new contexts.
2424

2525
Ping the `@rust-lang/libs` team on GitHub anytime. We’re all here to help!
2626

27-
If you don’t think you’re the best person to review a PR then use [`highfive`] to assign it to somebody else.
27+
If you don’t think you’re the best person to review a PR then use [`triagebot`][assignment] to assign it to somebody else.
2828

2929
## Finding reviews waiting for your input
3030

@@ -345,7 +345,7 @@ To try reduce noise in the docs from deprecated items, they should be moved to t
345345
[`rust-lang/rust-forge`]: https://github.com/rust-lang/rust-forge
346346
[`rfcbot`]: https://github.com/rust-lang/rfcbot-rs
347347
[`bors`]: https://github.com/rust-lang/homu
348-
[`highfive`]: https://github.com/rust-lang/highfive
348+
[assignment]: https://github.com/rust-lang/triagebot/wiki/Assignment
349349
[`crater`]: https://github.com/rust-lang/crater
350350
[`rust-timer`]: https://github.com/rust-lang-nursery/rustc-perf
351351
[Libs tracking issues]: https://github.com/rust-lang/rust/issues?q=label%3AC-tracking-issue+label%3AT-libs

src/release/rollups.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ queue has been merged.
4141
@bors r+ rollup=never p=<NUMBER_OF_PRS_IN_ROLLUP>
4242
````
4343
44-
3. If the rollup fails, use the logs rust-highfive (really it is
45-
rust-log-analyzer) provides to bisect the failure to a specific PR and do
44+
3. If the rollup fails, use the logs rust-log-analyzer
45+
provides to bisect the failure to a specific PR and do
4646
`@bors r-`. If the PR is running, you need to do `@bors r- retry`. Otherwise,
4747
your rollup succeeded. If it did, proceed to the next rollup (every now and
4848
then let `rollup=never` and toolstate PRs progress).
@@ -68,7 +68,7 @@ This is something you will learn to improve over time. Some basic tips include
6868
## Failed rollups
6969
If the rollup has failed, run the `@bors retry` command if the
7070
failure was spurious (e.g. due to a network problem or a timeout). If it wasn't spurious,
71-
find the offending PR and throw it out by copying a link to the rust-highfive comment,
71+
find the offending PR and throw it out by copying a link to the rust-logs-analyzer comment,
7272
and writing `Failed in <link_to_comment>, @bors r-`. Hopefully,
7373
the author or reviewer will give feedback to get the PR fixed or confirm that it's not
7474
at fault. The failed rollup PR can be closed.

src/release/triage-procedure.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
communicates that the PR is an experiment to test out some changes.
2929

3030
Also: [PRs with no status tags][no-status-tags]. This is useful to find PRs
31-
where highfive conked out and didn't assign a reviewer and thus didn't assign
31+
where rustbot conked out and didn't assign a reviewer and thus didn't assign
3232
[S-waiting-on-review]. These PRs can get lost otherwise. (Note that you should
3333
likely **not** triage PRs that have `r? @ghost` since that means the author does
3434
not need a review yet.)

0 commit comments

Comments
 (0)