Skip to content

Commit 8e3c120

Browse files
authored
Merge pull request #1009 from apiraino/link-bors-docs
Link bors help page
2 parents c5a716f + 6be1ea4 commit 8e3c120

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/compiler/reviews.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ be effective:
4545
the PR contains risks, is it sufficiently justified? Does the changes need ecosystem impact
4646
evaluation through crater runs?
4747
- Will the PR introduce significant perf changes? If there might be a perf regression, is
48-
it justified? Does the PR need a perf run?
48+
it justified? Does the PR need a perf run?
4949
- Can the reviewer perform the review sufficiently thorough and in a timely fashion?
5050
- Is the reviewer impartial enough to provide a sufficiently unbiased perspective? e.g. due
5151
to co-authorship (sufficiently significant changes to the PR made by the reviewer) or other
@@ -169,7 +169,7 @@ cleared up? Then you are in the clear.
169169

170170
If you are in doubt if something is contentious, give a heads up to `@rust-lang/compiler` and ask
171171
for another opinion. If you think a might contribution require broader team approval, check
172-
the [*Proposals, Approvals and Stabilization*](./proposals-and-stabilization.md) documentation.
172+
the [*Proposals, Approvals and Stabilization*](./proposals-and-stabilization.md) documentation.
173173

174174
### Reviewing and Mentoring
175175
In the course of mentoring someone through a PR it often happens that the reviewer has ended up
@@ -223,7 +223,7 @@ Require a doc comment on such APIs identifying which external consumers the API
223223
what kinds of purpose.
224224

225225
If you think a might contribution require broader team approval, check the [*Proposals, Approvals
226-
and Stabilization*](./proposals-and-stabilization.md) documentation.
226+
and Stabilization*](./proposals-and-stabilization.md) documentation.
227227

228228
Note that this can non-obviously bound supposedly-internal compiler APIs to external consumers.
229229
Convey to the external consumers (that are not `rust-lang/` projects) that we can offer the
@@ -326,18 +326,18 @@ specific PR that is being fully or partially reverted. Link to relevant issues a
326326
Retain the commit hash being reverted.
327327

328328
> **Example revert commit title and message**
329-
>
329+
>
330330
> ```text
331331
> Revert #131669 due to ICEs
332-
>
332+
>
333333
> Revert <https://github.com/rust-lang/rust/pull/131669> due to ICE
334334
> reports:
335-
>
335+
>
336336
> - <https://github.com/rust-lang/rust/issues/134059> (real-world)
337337
> - <https://github.com/rust-lang/rust/issues/134060> (fuzzing)
338-
>
338+
>
339339
> The changes can be re-landed with those cases addressed.
340-
>
340+
>
341341
> This reverts commit 703bb982303ecab02fec593899639b4c3faecddd, reversing
342342
> changes made to f415c07494b98e4559e4b13a9c5f867b0e6b2444.
343343
> ```
@@ -476,7 +476,7 @@ Rebasing is fine and often necessary, but changes in functionality typically req
476476
It is very helpful for the reviewer if the PR author can produce a brief summary of what has
477477
changed since last review, in addition to responding to individual review comments.
478478

479-
Please refer to [bors documentation for bot usage](../infra/docs/bors.md).
479+
Please refer to [bors documentation for bot usage](https://bors.rust-lang.org/help).
480480

481481
## Social aspects of reviewing
482482
First and foremost, PR authors and compiler reviews alike are expected to uphold the [Code of

0 commit comments

Comments
 (0)