Skip to content

Commit b761423

Browse files
michaelwoeristerjieyouxu
authored andcommitted
Incorporate feedback to review policy update.
1 parent ddd945b commit b761423

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/compiler/reviews.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ There are a number of requirements that need to be met in order for reviewing to
2020
- Reviewers must have a sufficient **understanding of the code** under review.
2121
> This is important to help spot non-obvious, unintentional side effects of a given change.
2222
- Pull requests must provide (1) a concise high-level **description of the change** and (2) the **rationale** behind it.
23-
For the rational to be even more useful, authors are encouraged to list potential **points of contention**.
23+
For the rationale to be even more useful, authors are encouraged to list potential **points of contention**.
2424
> Reviewing code is difficult and reviewers only have a limited amount of time to do it.
2525
> Jump-starting the review process by not making the reviewer puzzle together the intention and context
2626
> of a pull request will not only speed things up but also improve the quality of the review.
@@ -84,9 +84,12 @@ This section lists a few common cases together with guidance on how to deal with
8484
It's polite to leave a comment asking them if they can take over --
8585
but you don't have to make sure beforehand that they can actually do it.
8686
- If you don't know the code well or already have too much on your plate,
87-
ask highfive to roll the dice again via `r? @rust-lang/compiler-contributors`.
87+
ask highfive to roll the dice again via `r? rust-lang/compiler-contributors`.
8888

8989
You can also always ask specific compiler team members for help finding a reviewer.
90+
That being said, you are always welcome to do an initial review (to the extent you are comformtable with)
91+
and then pass the PR on to the final reviewer.
92+
This way the PR author will get helpful feedback sooner and subsequent reviewers will have less work to do.
9093

9194
* ### It is unclear if something constitutes a major change
9295
Deciding if something is a "major change" requiring an [MCP][mcp] is not always straightforward.

0 commit comments

Comments
 (0)