Skip to content

Commit 13ddc3d

Browse files
committed
Rename selector to reduce future confusion
1 parent 45c3831 commit 13ddc3d

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

ui/frontend/AdvancedOptionsMenu.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import * as selectors from './selectors';
99
import { Backtrace, Edition } from './types';
1010

1111
const AdvancedOptionsMenu: React.SFC = () => {
12-
const isEditionSet = useSelector(selectors.getEditionSet);
12+
const isEditionDefault = useSelector(selectors.isEditionDefault);
1313
const edition = useSelector((state: State) => state.configuration.edition);
1414
const isBacktraceSet = useSelector(selectors.getBacktraceSet);
1515
const backtrace = useSelector((state: State) => state.configuration.backtrace);
@@ -24,7 +24,7 @@ const AdvancedOptionsMenu: React.SFC = () => {
2424
<SelectConfig
2525
name="Edition"
2626
value={edition}
27-
isNotDefault={isEditionSet}
27+
isNotDefault={!isEditionDefault}
2828
onChange={changeEdition}
2929
>
3030
<option value={Edition.Rust2015}>2015</option>

ui/frontend/selectors/index.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,19 +119,19 @@ export const getChannelLabel = (state: State) => {
119119
return `${channel}`;
120120
};
121121

122-
export const getEditionSet = createSelector(
122+
export const isEditionDefault = createSelector(
123123
editionSelector,
124-
edition => edition !== Edition.Rust2018,
124+
edition => edition == Edition.Rust2018,
125125
);
126126

127127
export const getBacktraceSet = (state: State) => (
128128
state.configuration.backtrace !== Backtrace.Disabled
129129
);
130130

131131
export const getAdvancedOptionsSet = createSelector(
132-
getEditionSet, getBacktraceSet,
133-
(editionSet, backtraceSet) => (
134-
editionSet || backtraceSet
132+
isEditionDefault, getBacktraceSet,
133+
(editionDefault, backtraceSet) => (
134+
!editionDefault || backtraceSet
135135
),
136136
);
137137

0 commit comments

Comments
 (0)