extra function to create issues

Author: nikomatsakis

mdbook-goals/src/gh/issues.rs

@@ -5,6 +5,8 @@ use std::{
 
 use serde::{Deserialize, Serialize};
 
+use crate::util::comma;
+
 #[derive(Debug, Serialize, Deserialize, PartialEq, Eq, PartialOrd, Ord)]
 pub struct ExistingGithubIssue {
     pub number: u64,
@@ -86,6 +88,42 @@ pub fn list_issue_titles_in_milestone(
         .collect())
 }
 
+pub fn create_issue(
+    repository: &str,
+    body: &str,
+    title: &str,
+    labels: &[String],
+    assignees: &BTreeSet<String>,
+    milestone: &str,
+) -> anyhow::Result<()> {
+    let output = Command::new("gh")
+        .arg("-R")
+        .arg(&repository)
+        .arg("issue")
+        .arg("create")
+        .arg("-b")
+        .arg(&body)
+        .arg("-t")
+        .arg(&title)
+        .arg("-l")
+        .arg(labels.join(","))
+        .arg("-a")
+        .arg(comma(&assignees))
+        .arg("-m")
+        .arg(&milestone)
+        .output()?;
+
+    if !output.status.success() {
+        Err(anyhow::anyhow!(
+            "failed to create issue `{}`: {}",
+            title,
+            String::from_utf8_lossy(&output.stderr)
+        ))
+    } else {
+        Ok(())
+    }
+}
+
 const LOCK_TEXT: &str = "This issue is intended for status updates only.\n\nFor general questions or comments, please contact the owner(s) directly.";
 
 impl ExistingGithubIssue {

mdbook-goals/src/rfc.rs

@@ -12,11 +12,12 @@ use regex::Regex;
 use crate::{
     gh::{
         issue_id::IssueId,
-        issues::{list_issue_titles_in_milestone, lock_issue},
+        issues::{create_issue, list_issue_titles_in_milestone, lock_issue},
         labels::GhLabel,
     },
     goal::{self, GoalDocument, ParsedOwners, PlanItem, Status},
     team::{get_person_data, TeamName},
+    util::comma,
 };
 
 fn validate_path(path: &Path) -> anyhow::Result<String> {
@@ -465,34 +466,11 @@ impl GithubAction<'_> {
                         goal_document: _,
                     },
             } => {
-                let output = Command::new("gh")
-                    .arg("-R")
-                    .arg(&repository)
-                    .arg("issue")
-                    .arg("create")
-                    .arg("-b")
-                    .arg(&body)
-                    .arg("-t")
-                    .arg(&title)
-                    .arg("-l")
-                    .arg(labels.join(","))
-                    .arg("-a")
-                    .arg(comma(&assignees))
-                    .arg("-m")
-                    .arg(&timeframe)
-                    .output()?;
-
-                if !output.status.success() {
-                    Err(anyhow::anyhow!(
-                        "failed to create issue `{}`: {}",
-                        title,
-                        String::from_utf8_lossy(&output.stderr)
-                    ))
-                } else {
-                    Ok(())
-                }
+                create_issue(repository, &body, &title, &labels, &assignees, timeframe)?;
 
                 // Note: the issue is not locked, but we will reloop around later.
+
+                Ok(())
             }
             GithubAction::SyncAssignees {
                 number,
@@ -536,8 +514,3 @@ impl GithubAction<'_> {
         }
     }
 }
-
-/// Returns a comma-separated list of the strings in `s` (no spaces).
-fn comma(s: &BTreeSet<String>) -> String {
-    s.iter().map(|s| &s[..]).collect::<Vec<_>>().join(",")
-}

mdbook-goals/src/util.rs

@@ -1,4 +1,5 @@
 use std::{
+    collections::BTreeSet,
     fmt::{Display, Write},
     path::{Path, PathBuf},
 };
@@ -122,3 +123,8 @@ pub fn markdown_files(directory_path: &Path) -> anyhow::Result<Vec<(PathBuf, Pat
     }
     Ok(files)
 }
+
+/// Returns a comma-separated list of the strings in `s` (no spaces).
+pub fn comma(s: &BTreeSet<String>) -> String {
+    s.iter().map(|s| &s[..]).collect::<Vec<_>>().join(",")
+}