move flagship test to a fn on ExistingGithubIssue

Author: nikomatsakis

mdbook-goals/src/gh/issues.rs

@@ -242,6 +242,11 @@ impl ExistingGithubIssue {
     pub fn has_label(&self, name: &str) -> bool {
         self.labels.iter().any(|label| label.name == name)
     }
+
+    /// True if the issue has the label for a flagship goal.
+    pub fn has_flagship_label(&self) -> bool {
+        self.has_label("flagship")
+    }
 }
 
 pub fn lock_issue(repository: &Repository, number: u64) -> anyhow::Result<()> {

mdbook-goals/src/json.rs

@@ -36,7 +36,7 @@ pub(super) fn generate_json(
                 TrackingIssue {
                     number: issue.number,
                     title,
-                    flagship: is_flagship(&issue),
+                    flagship: issue.has_flagship_label(),
                     progress,
                     assignees: issue.assignees.into_iter().collect(),
                     updates: updates(issue.comments),
@@ -224,10 +224,6 @@ fn try_checkboxes(issue: &ExistingGithubIssue) -> anyhow::Result<Progress> {
     }
 }
 
-fn is_flagship(issue: &ExistingGithubIssue) -> bool {
-    issue.has_label("flagship")
-}
-
 fn updates(comments: Vec<ExistingGithubComment>) -> Vec<TrackingIssueUpdate> {
     comments
         .into_iter()