Add open64 and rename symbol_name_without_mangling

Author: Urgau

compiler/rustc_lint/src/redefining_runtime_symbols.rs

@@ -27,7 +27,7 @@ declare_lint! {
     ///
     /// The symbols currently checked are respectively:
     ///  - from `core`[^1]: `memcpy`, `memmove`, `memset`, `memcmp`, `bcmp`, `strlen`
-    ///  - from `std`: `read`, `write`, `open`, `close`
+    ///  - from `std`: `open`/`open64`, `read`, `write`, `close`
     ///
     /// [^1]: https://doc.rust-lang.org/core/index.html#how-to-use-the-core-library
     pub REDEFINING_RUNTIME_SYMBOLS,
@@ -39,7 +39,7 @@ declare_lint_pass!(RedefiningRuntimeSymbols => [REDEFINING_RUNTIME_SYMBOLS]);
 
 static CORE_RUNTIME_SYMBOLS: &[&str] = &["memcpy", "memmove", "memset", "memcmp", "bcmp", "strlen"];
 
-static STD_RUNTIME_SYMBOLS: &[&str] = &["open", "read", "write", "close"];
+static STD_RUNTIME_SYMBOLS: &[&str] = &["open", "open64", "read", "write", "close"];
 
 impl<'tcx> LateLintPass<'tcx> for RedefiningRuntimeSymbols {
     fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx hir::Item<'tcx>) {
@@ -52,7 +52,7 @@ impl<'tcx> LateLintPass<'tcx> for RedefiningRuntimeSymbols {
 
         // Compute the symbol name of our item (without mangling, as our mangling cannot ever
         // conflict with runtime symbols).
-        let Some(symbol_name) = rustc_symbol_mangling::symbol_name_without_mangling(
+        let Some(symbol_name) = rustc_symbol_mangling::symbol_name_from_attrs(
             cx.tcx,
             rustc_middle::ty::InstanceKind::Item(item.owner_id.to_def_id()),
         ) else {

compiler/rustc_symbol_mangling/src/lib.rs

@@ -158,7 +158,7 @@ pub fn typeid_for_trait_ref<'tcx>(
     v0::mangle_typeid_for_trait_ref(tcx, trait_ref)
 }
 
-pub fn symbol_name_without_mangling<'tcx>(
+pub fn symbol_name_from_attrs<'tcx>(
     tcx: TyCtxt<'tcx>,
     instance_kind: InstanceKind<'tcx>,
 ) -> Option<String> {
@@ -252,7 +252,7 @@ fn compute_symbol_name<'tcx>(
 
     debug!("symbol_name(def_id={:?}, args={:?})", def_id, args);
 
-    if let Some(symbol) = symbol_name_without_mangling(tcx, instance.def) {
+    if let Some(symbol) = symbol_name_from_attrs(tcx, instance.def) {
         return symbol;
     }
 

tests/ui/lint/redefining-runtime-symbols.rs

@@ -39,6 +39,10 @@ pub static strlen: () = ();
 pub fn open() {}
 //~^ WARN redefinition of the runtime `open` symbol
 
+#[no_mangle]
+pub fn open64() {}
+//~^ WARN redefinition of the runtime `open64` symbol
+
 #[export_name = "read"]
 pub async fn read1() {}
 //~^ WARN redefinition of the runtime `read` symbol

tests/ui/lint/redefining-runtime-symbols.stderr

@@ -73,9 +73,19 @@ LL | pub fn open() {}
    = note: see <https://doc.rust-lang.org/core/index.html#how-to-use-the-core-library> for the more details
    = help: either allow this lint or remove any `#[unsafe(no_mangle)]` or `#[unsafe(export_name = "open")]`
 
-warning: redefinition of the runtime `read` symbol used by the standard library
+warning: redefinition of the runtime `open64` symbol used by the standard library
   --> $DIR/redefining-runtime-symbols.rs:43:1
    |
+LL | pub fn open64() {}
+   | ^^^^^^^^^^^^^^^^^^
+   |
+   = note: extra care must be taken when redefining those symbols, they must match exactly (ABI, function arguments, function return type, behavior, ...)
+   = note: see <https://doc.rust-lang.org/core/index.html#how-to-use-the-core-library> for the more details
+   = help: either allow this lint or remove any `#[unsafe(no_mangle)]` or `#[unsafe(export_name = "open64")]`
+
+warning: redefinition of the runtime `read` symbol used by the standard library
+  --> $DIR/redefining-runtime-symbols.rs:47:1
+   |
 LL | pub async fn read1() {}
    | ^^^^^^^^^^^^^^^^^^^^^^^
    |
@@ -84,7 +94,7 @@ LL | pub async fn read1() {}
    = help: either allow this lint or remove any `#[unsafe(no_mangle)]` or `#[unsafe(export_name = "read")]`
 
 warning: redefinition of the runtime `write` symbol used by the standard library
-  --> $DIR/redefining-runtime-symbols.rs:47:1
+  --> $DIR/redefining-runtime-symbols.rs:51:1
    |
 LL | pub fn write1() {}
    | ^^^^^^^^^^^^^^^^^^
@@ -94,7 +104,7 @@ LL | pub fn write1() {}
    = help: either allow this lint or remove any `#[unsafe(no_mangle)]` or `#[unsafe(export_name = "write")]`
 
 warning: redefinition of the runtime `close` symbol used by the standard library
-  --> $DIR/redefining-runtime-symbols.rs:51:1
+  --> $DIR/redefining-runtime-symbols.rs:55:1
    |
 LL | pub fn close_() {}
    | ^^^^^^^^^^^^^^^^^^
@@ -103,5 +113,5 @@ LL | pub fn close_() {}
    = note: see <https://doc.rust-lang.org/core/index.html#how-to-use-the-core-library> for the more details
    = help: either allow this lint or remove any `#[unsafe(no_mangle)]` or `#[unsafe(export_name = "close")]`
 
-warning: 10 warnings emitted
+warning: 11 warnings emitted