don't apply clone-like deprioritization on generics

because we're not unifying the whole function at once, a function
like `U -> T` would otherwise be counted as "clone-like" because
the generics will just unify with anything when done seperatly.

Author: lolbinarycat

src/librustdoc/html/static/js/search.js

@@ -3559,19 +3559,22 @@ class DocSearch {
 
         /**
          * This function checks if the given list contains any
-         * types mentioned in the query.
+         * (non-generic) types mentioned in the query.
          *
          * @param {Array<FunctionType>} list    - A list of function types.
          * @param {[FunctionType]} where_clause - Trait bounds for generic items.
          */
         function containsTypeFromQuery(list, where_clause) {
             if (!list) return false;
             for (const ty of parsedQuery.returned) {
+                // negative type ids are generics
+                if (ty < 0) continue;
                 if (checkIfInList(list, ty, where_clause, null, 0)) {
                     return true;
                 }
             }
             for (const ty of parsedQuery.elems) {
+                if (ty < 0) continue;
                 if (checkIfInList(list, ty, where_clause, null, 0)) {
                     return true;
                 }

tests/rustdoc-js-std/return-based-sort.js

@@ -18,4 +18,13 @@ const EXPECTED = [
             { 'path': 'core::alloc::AllocError', 'name': 'clone' },
          ],
     },
+    {
+        'query': '-> &str',
+        'others': [
+            // type_name_of_val should not be consider clone-like
+            { 'path': 'core::any', 'name': 'type_name_of_val' },
+            // this returns `Option<&str>`, and thus should be sorted lower
+            { 'path': 'core::str::Split', 'name': 'next' },
+         ],
+    },    
 ]