Skip to content

Commit 11ea573

Browse files
authored
Rollup merge of #146172 - RalfJung:triagebot-keyword-mentions, r=Urgau
triagebot: configure some pings when certain attributes are used Let's try this out in practice. :) Cc `@rust-lang/miri` `@rust-lang/wg-const-eval` `@Urgau`
2 parents c81fffa + 2d20ee7 commit 11ea573

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

src/tools/tidy/src/triagebot.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,12 @@ pub fn check(path: &Path, bad: &mut bool) {
1919

2020
// Check [mentions."*"] sections, i.e. [mentions."compiler/rustc_const_eval/src/"]
2121
if let Some(Value::Table(mentions)) = config.get("mentions") {
22-
for path_str in mentions.keys() {
22+
for (entry_key, entry_val) in mentions.iter() {
23+
// If the type is set to something other than "filename", then this is not a path.
24+
if entry_val.get("type").is_some_and(|t| t.as_str().unwrap_or_default() != "filename") {
25+
continue;
26+
}
27+
let path_str = entry_key;
2328
// Remove quotes from the path
2429
let clean_path = path_str.trim_matches('"');
2530
let full_path = path.join(clean_path);

triagebot.toml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1306,6 +1306,21 @@ cc = ["@m-ou-se"]
13061306
[mentions."compiler/rustc_ast_lowering/src/format.rs"]
13071307
cc = ["@m-ou-se"]
13081308

1309+
[mentions."#[miri::intrinsic_fallback_is_spec]"]
1310+
type = "content"
1311+
message = """
1312+
`#[miri::intrinsic_fallback_is_spec]` must only be used if the function actively checks for all UB cases,
1313+
and explores the possible non-determinism of the intrinsic.
1314+
"""
1315+
cc = ["@rust-lang/miri"]
1316+
[mentions."#[rustc_allow_const_fn_unstable]"]
1317+
type = "content"
1318+
message = """
1319+
`#[rustc_allow_const_fn_unstable]` needs careful audit to avoid accidentally exposing unstable
1320+
implementation details on stable.
1321+
"""
1322+
cc = ["@rust-lang/wg-const-eval"]
1323+
13091324

13101325
# ------------------------------------------------------------------------------
13111326
# PR assignments

0 commit comments

Comments
 (0)