Apply suggestions from code review

Co-authored-by: Jubilee <[email protected]>

Author: TimTheBig

library/alloc/src/bstr.rs

@@ -180,10 +180,7 @@ impl Default for ByteString {
 //
 // #[unstable(feature = "bstr", issue = "134915")]
 // impl<'a, const N: usize> From<&'a [u8; N]> for ByteString {
-//     /// Make a `ByteString` from a byte array ref.
-//     ///
-//     /// ## Cost
-//     /// Allocates a new `Vec`
+//     /// Allocate a new `ByteString` with a copy of the bytes in the array.
 //     #[inline]
 //     fn from(s: &'a [u8; N]) -> Self {
 //         ByteString(s.as_slice().to_vec())
@@ -192,10 +189,7 @@ impl Default for ByteString {
 //
 // #[unstable(feature = "bstr", issue = "134915")]
 // impl<const N: usize> From<[u8; N]> for ByteString {
-//     /// Make a `ByteString` from a byte array.
-//     ///
-//     /// ## Cost
-//     /// Allocates a new `Vec`
+//     /// Allocate a new `ByteString` with a copy of the bytes in the array.
 //     #[inline]
 //     fn from(s: [u8; N]) -> Self {
 //         ByteString(s.as_slice().to_vec())
@@ -204,10 +198,7 @@ impl Default for ByteString {
 //
 // #[unstable(feature = "bstr", issue = "134915")]
 // impl<'a> From<&'a [u8]> for ByteString {
-//     /// Make a `ByteString` from a byte slice.
-//     ///
-//     /// ## Cost
-//     /// Allocates a new `Vec`
+//     /// Allocate a new `ByteString` with a copy of the bytes in the array.
 //     #[inline]
 //     fn from(s: &'a [u8]) -> Self {
 //         ByteString(s.to_vec())
@@ -236,10 +227,7 @@ impl From<ByteString> for Vec<u8> {
 //
 // #[unstable(feature = "bstr", issue = "134915")]
 // impl<'a> From<&'a str> for ByteString {
-//     /// Make a `ByteString` from a string slices bytes.
-//     ///
-//     /// ## Cost
-//     /// Allocates a new `Vec`
+//     /// Allocate a new `ByteString` with a copy of the bytes in the slice.
 //     #[inline]
 //     fn from(s: &'a str) -> Self {
 //         ByteString(s.as_bytes().to_vec())

library/alloc/src/collections/mod.rs

@@ -130,7 +130,6 @@ pub use realalloc::collections::TryReserveErrorKind;
 )]
 #[cfg(not(test))]
 impl From<TryReserveErrorKind> for TryReserveError {
-    /// Wrap kind in `TryReserveError`.
     #[inline]
     fn from(kind: TryReserveErrorKind) -> Self {
         Self { kind }

library/core/src/num/error.rs

@@ -27,7 +27,6 @@ impl Error for TryFromIntError {
 
 #[stable(feature = "try_from", since = "1.34.0")]
 impl From<Infallible> for TryFromIntError {
-    /// Convert `Infallible` into an error that can happen.
     #[inline]
     fn from(x: Infallible) -> TryFromIntError {
         match x {}
@@ -36,7 +35,6 @@ impl From<Infallible> for TryFromIntError {
 
 #[unstable(feature = "never_type", issue = "35121")]
 impl From<!> for TryFromIntError {
-    /// Convert `!` into an error that can happen.
     #[inline]
     fn from(never: !) -> TryFromIntError {
         // Match rather than coerce to make sure that code like

library/portable-simd/crates/core_simd/src/masks/full_masks.rs

@@ -238,7 +238,6 @@ where
     T: MaskElement,
     LaneCount<N>: SupportedLaneCount,
 {
-    /// Return the `MaskElement` of the `Mask`
     #[inline]
     fn from(value: Mask<T, N>) -> Self {
         value.0

library/proc_macro/src/bridge/rpc.rs

@@ -266,10 +266,7 @@ impl From<Box<dyn Any + Send>> for PanicMessage {
 }
 
 impl From<PanicMessage> for Box<dyn Any + Send> {
-    /// Return the inner message wrapped in `Box`.
-    ///
-    /// ## Cost
-    /// Allocates a new `Box` on the heap
+    /// Wrap the inner message in a newly allocated `Box`.
     fn from(val: PanicMessage) -> Self {
         match val {
             PanicMessage::StaticStr(s) => Box::new(s),

library/proc_macro/src/lib.rs

@@ -722,31 +722,27 @@ impl fmt::Debug for TokenTree {
 
 #[stable(feature = "proc_macro_lib2", since = "1.29.0")]
 impl From<Group> for TokenTree {
-    /// Wrap `Group` in `TokenTree::Group`
     fn from(g: Group) -> TokenTree {
         TokenTree::Group(g)
     }
 }
 
 #[stable(feature = "proc_macro_lib2", since = "1.29.0")]
 impl From<Ident> for TokenTree {
-    /// Wrap `Ident` in `TokenTree::Ident`
     fn from(g: Ident) -> TokenTree {
         TokenTree::Ident(g)
     }
 }
 
 #[stable(feature = "proc_macro_lib2", since = "1.29.0")]
 impl From<Punct> for TokenTree {
-    /// Wrap `Punct` in `TokenTree::Punct`
     fn from(g: Punct) -> TokenTree {
         TokenTree::Punct(g)
     }
 }
 
 #[stable(feature = "proc_macro_lib2", since = "1.29.0")]
 impl From<Literal> for TokenTree {
-    /// Wrap `Literal` in `TokenTree::Literal`
     fn from(g: Literal) -> TokenTree {
         TokenTree::Literal(g)
     }

library/std/src/os/xous/ffi/definitions.rs

@@ -266,7 +266,7 @@ impl Into<[u32; 4]> for ServerAddress {
 pub(crate) struct ThreadId(usize);
 
 impl From<usize> for ThreadId {
-    /// Make a `ThreadId` with `usize` as inner
+    /// Make a `ThreadId` with `usize` as the id
     fn from(src: usize) -> ThreadId {
         ThreadId(src)
     }

library/std/src/sys/process/windows.rs

@@ -121,7 +121,7 @@ impl PartialEq<str> for EnvKey {
 // Environment variable keys should preserve their original case even though
 // they are compared using a caseless string mapping.
 impl From<OsString> for EnvKey {
-    /// Create a new `EnvKey` from `OsString` and it's encode wide iter.
+    /// Create a new `EnvKey` from `OsString` and its encode wide iter.
     ///
     /// ## Cost
     /// Has to collect `OsString.encode_wide` which allocates a new `Vec`