Remove obsolete and confusing comment

moxian · moxian · commit 16db0e234b5b · 2025-05-08T19:43:05.000-07:00
This comment from 2017 says "every error should have an associated error code" However, a more recent rustc-dev-guide doc from 2020 suggests that this is not the case, and that errorcode-less errors are fine and sometimes even preferable to errorcode-full ones: rust-lang/rustc-dev-guide#967
diff --git a/compiler/rustc_errors/src/lib.rs b/compiler/rustc_errors/src/lib.rs
@@ -1304,7 +1304,6 @@ impl<'a> DiagCtxtHandle<'a> {
         self.create_almost_fatal(fatal).emit()
     }
 
-    // FIXME: This method should be removed (every error should have an associated error code).
     #[rustc_lint_diagnostics]
     #[track_caller]
     pub fn struct_err(self, msg: impl Into<DiagMessage>) -> Diag<'a> {

Original file line number	Diff line number	Diff line change
`@@ -1304,7 +1304,6 @@ impl<'a> DiagCtxtHandle<'a> {`
`1304`	`1304`	`self.create_almost_fatal(fatal).emit()`
`1305`	`1305`	`}`
`1306`	`1306`
`1307`		`- // FIXME: This method should be removed (every error should have an associated error code).`
`1308`	`1307`	`#[rustc_lint_diagnostics]`
`1309`	`1308`	`#[track_caller]`
`1310`	`1309`	`pub fn struct_err(self, msg: impl Into<DiagMessage>) -> Diag<'a> {`