Skip to content

Commit 1bfc216

Browse files
Ignore failing gcc backend testsuite directly in Dockerfile
1 parent 039fdd2 commit 1bfc216

File tree

2 files changed

+3
-30
lines changed
  • src

2 files changed

+3
-30
lines changed

src/bootstrap/src/core/build_steps/test.rs

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1573,21 +1573,6 @@ impl Step for Coverage {
15731573
let compiler = run.builder.compiler(run.builder.top_stage, run.build_triple());
15741574
let target = run.target;
15751575

1576-
// GCC cannot run coverage tests.
1577-
if let Some(codegen_backend) = run.builder.config.cmd.test_codegen_backend() {
1578-
eprintln!(
1579-
"WARNING: Already testing with GCC backend so ignoring `rustc_codegen_gcc` testsuite"
1580-
);
1581-
if codegen_backend.is_gcc() {
1582-
return;
1583-
}
1584-
} else if run.builder.config.default_codegen_backend(compiler.host).is_gcc() {
1585-
eprintln!(
1586-
"WARNING: Already testing with GCC backend so ignoring `rustc_codegen_gcc` testsuite"
1587-
);
1588-
return;
1589-
}
1590-
15911576
// List of (coverage) test modes that the coverage test suite will be
15921577
// run in. It's OK for this to contain duplicates, because the call to
15931578
// `Builder::ensure` below will take care of deduplication.
@@ -3750,20 +3735,6 @@ impl Step for CodegenGCC {
37503735
return;
37513736
}
37523737

3753-
// It we were running with GCC backend tests, no need to run these tests.
3754-
if let Some(codegen_backend) = run.builder.config.cmd.test_codegen_backend() {
3755-
if codegen_backend.is_gcc() {
3756-
return;
3757-
}
3758-
} else if run
3759-
.builder
3760-
.config
3761-
.default_codegen_backend(compilers.target_compiler().host)
3762-
.is_gcc()
3763-
{
3764-
return;
3765-
}
3766-
37673738
if builder.download_rustc() {
37683739
builder.info("CI rustc uses the default codegen backend. skipping");
37693740
return;

src/ci/docker/host-x86_64/x86_64-gnu-gcc/Dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ ENV RUST_CONFIGURE_ARGS \
4141
--set 'rust.codegen-backends=[\"llvm\",\"gcc\"]'
4242
ENV SCRIPT python3 ../x.py \
4343
--stage 2 \
44-
test \
44+
test tests \
4545
--test-codegen-backend gcc \
46+
--skip tests/coverage \
47+
--skip tests/coverage-run-rustdoc \
4648
--set 'rust.codegen-backends=[\"llvm\",\"gcc\"]'

0 commit comments

Comments
 (0)