Fixed test and moved it into right directory

Author: Kivooeo

compiler/rustc_hir_typeck/messages.ftl

@@ -153,6 +153,14 @@ hir_typeck_no_associated_item = no {$item_kind} named `{$item_ident}` found for
     *[other] {" "}in the current scope
 }
 
+hir_typeck_expr_rarrow_call = `->` used for field access or method call
+    .suggestion = try using `.` instead
+    .help = the `.` operator will automatically dereference the value, except if the value is a raw pointer
+
+hir_typeck_expr_rarrow_call_on_a_raw_ptr = `->` used for field access or method call
+    .suggestion = try using `.` on a manually dereferenced value
+    .help = the value is a raw pointer, derefence it with `*` first
+
 hir_typeck_no_field_on_type = no field `{$field}` on type `{$ty}`
 
 hir_typeck_no_field_on_variant = no field named `{$field}` on enum variant `{$container}::{$ident}`

compiler/rustc_parse/messages.ftl

@@ -246,10 +246,6 @@ parse_expected_struct_field = expected one of `,`, `:`, or `{"}"}`, found `{$tok
 
 parse_expected_trait_in_trait_impl_found_type = expected a trait, found type
 
-parse_expr_rarrow_call = `->` used for field access or method call
-    .suggestion = try using `.` instead
-    .help = the `.` operator will automatically dereference the value, except if the value is a raw pointer
-
 parse_extern_crate_name_with_dashes = crate name using dashes are not valid in `extern crate` statements
     .label = dash-separated idents are not valid
     .suggestion = if the original crate name uses dashes you need to use underscores in the code

compiler/rustc_parse/src/errors.rs

@@ -3333,7 +3333,6 @@ pub(crate) struct AsyncImpl {
 #[help]
 pub(crate) struct ExprRArrowCall {
     #[primary_span]
-    #[suggestion(style = "verbose", applicability = "machine-applicable", code = ".")]
     pub span: Span,
 }
 

tests/ui/parser/expr-rarrow-call-on-a-raw-pointer.fixed

@@ -0,0 +1,23 @@
+//@ run-rustfix
+#![allow(
+    dead_code,
+    unused_must_use
+)]
+
+struct Named {
+    foo: usize,
+}
+
+struct Unnamed(usize);
+
+unsafe fn named_struct_field_access(named: *mut Named) {
+    (*named).foo += 1; //~ ERROR `->` used for field access or method call
+    //~^ ERROR no field `foo` on type `*mut Named`
+}
+
+unsafe fn unnamed_struct_field_access(unnamed: *mut Unnamed) {
+    (*unnamed).0 += 1; //~ ERROR `->` used for field access or method call
+    //~^ ERROR no field `0` on type `*mut Unnamed`
+}
+
+fn main() {}

tests/ui/suggestions/expr-rarrow-call-on-a-raw-pointer.rs renamed to tests/ui/parser/expr-rarrow-call-on-a-raw-pointer.rs

@@ -10,12 +10,14 @@ struct Named {
 
 struct Unnamed(usize);
 
-fn named_struct_field_access(named: *mut Named) {
+unsafe fn named_struct_field_access(named: *mut Named) {
     named->foo += 1; //~ ERROR `->` used for field access or method call
+    //~^ ERROR no field `foo` on type `*mut Named`
 }
 
-fn unnamed_struct_field_access(unnamed: *mut Unnamed) {
+unsafe fn unnamed_struct_field_access(unnamed: *mut Unnamed) {
     unnamed->0 += 1; //~ ERROR `->` used for field access or method call
+    //~^ ERROR no field `0` on type `*mut Unnamed`
 }
 
 fn main() {}

tests/ui/suggestions/expr-rarrow-call-on-a-raw-pointer.stderr renamed to tests/ui/parser/expr-rarrow-call-on-a-raw-pointer.stderr

@@ -5,24 +5,14 @@ LL |     named->foo += 1;
    |          ^^
    |
    = help: the `.` operator will automatically dereference the value, except if the value is a raw pointer
-help: try using `.` instead
-   |
-LL -     named->foo += 1;
-LL +     named.foo += 1;
-   |
 
 error: `->` used for field access or method call
-  --> $DIR/expr-rarrow-call-on-a-raw-pointer.rs:18:12
+  --> $DIR/expr-rarrow-call-on-a-raw-pointer.rs:19:12
    |
 LL |     unnamed->0 += 1;
    |            ^^
    |
    = help: the `.` operator will automatically dereference the value, except if the value is a raw pointer
-help: try using `.` instead
-   |
-LL -     unnamed->0 += 1;
-LL +     unnamed.0 += 1;
-   |
 
 error[E0609]: no field `foo` on type `*mut Named`
   --> $DIR/expr-rarrow-call-on-a-raw-pointer.rs:14:12
@@ -37,7 +27,7 @@ LL +     (*named).foo += 1;
    |
 
 error[E0609]: no field `0` on type `*mut Unnamed`
-  --> $DIR/expr-rarrow-call-on-a-raw-pointer.rs:18:14
+  --> $DIR/expr-rarrow-call-on-a-raw-pointer.rs:19:14
    |
 LL |     unnamed->0 += 1;
    |              ^ unknown field