|
1 |
| -use super::FnCtxt; |
| 1 | +use rustc_hir::def::DefKind; |
| 2 | +use rustc_hir_analysis::errors::TaitForwardCompat2; |
| 3 | +use rustc_infer::traits::ObligationCause; |
| 4 | +use rustc_middle::ty::{ |
| 5 | + self, DefiningScopeKind, EarlyBinder, OpaqueHiddenType, OpaqueTypeKey, TypeVisitableExt, |
| 6 | + TypingMode, |
| 7 | +}; |
| 8 | +use rustc_trait_selection::error_reporting::infer::need_type_info::TypeAnnotationNeeded; |
| 9 | +use rustc_trait_selection::opaque_types::{ |
| 10 | + NonDefiningUseReason, opaque_type_has_defining_use_args, |
| 11 | +}; |
| 12 | +use rustc_trait_selection::solve; |
| 13 | +use tracing::{debug, instrument}; |
| 14 | + |
| 15 | +use crate::FnCtxt; |
| 16 | + |
2 | 17 | impl<'tcx> FnCtxt<'_, 'tcx> {
|
| 18 | + /// This takes all the opaque type uses during HIR typeck. It first computes |
| 19 | + /// the concrete hidden type by iterating over all defining uses. |
| 20 | + /// |
| 21 | + /// A use during HIR typeck is defining if all non-lifetime arguments are |
| 22 | + /// unique generic parameters and the hidden type does not reference any |
| 23 | + /// inference variables. |
| 24 | + /// |
| 25 | + /// It then uses these defining uses to guide inference for all other uses. |
| 26 | + #[instrument(level = "debug", skip(self))] |
| 27 | + pub(super) fn handle_opaque_type_uses_next(&mut self) { |
| 28 | + // We clone the opaques instead of stealing them here as they are still used for |
| 29 | + // normalization in the next generation trait solver. |
| 30 | + let mut opaque_types: Vec<_> = self.infcx.clone_opaque_types(); |
| 31 | + let num_entries = self.inner.borrow_mut().opaque_types().num_entries(); |
| 32 | + let prev = self.checked_opaque_types_storage_entries.replace(Some(num_entries)); |
| 33 | + debug_assert_eq!(prev, None); |
| 34 | + for entry in &mut opaque_types { |
| 35 | + *entry = self.resolve_vars_if_possible(*entry); |
| 36 | + } |
| 37 | + debug!(?opaque_types); |
| 38 | + |
| 39 | + self.compute_concrete_opaque_types(&opaque_types); |
| 40 | + self.apply_computed_concrete_opaque_types(&opaque_types); |
| 41 | + } |
| 42 | +} |
| 43 | + |
| 44 | +enum UsageKind<'tcx> { |
| 45 | + None, |
| 46 | + NonDefiningUse(OpaqueHiddenType<'tcx>), |
| 47 | + UnconstrainedHiddenType(OpaqueHiddenType<'tcx>), |
| 48 | + HasDefiningUse, |
| 49 | +} |
| 50 | + |
| 51 | +impl<'tcx> UsageKind<'tcx> { |
| 52 | + fn merge(&mut self, other: UsageKind<'tcx>) { |
| 53 | + match (&*self, &other) { |
| 54 | + (UsageKind::HasDefiningUse, _) | (_, UsageKind::None) => unreachable!(), |
| 55 | + (UsageKind::None, _) => *self = other, |
| 56 | + // When mergining non-defining uses, prefer earlier ones. This means |
| 57 | + // the error happens as early as possible. |
| 58 | + ( |
| 59 | + UsageKind::NonDefiningUse(..) | UsageKind::UnconstrainedHiddenType(..), |
| 60 | + UsageKind::NonDefiningUse(..), |
| 61 | + ) => {} |
| 62 | + // When merging unconstrained hidden types, we prefer later ones. This is |
| 63 | + // used as in most cases, the defining use is the final return statement |
| 64 | + // of our function, and other uses with defining arguments are likely not |
| 65 | + // intended to be defining. |
| 66 | + ( |
| 67 | + UsageKind::NonDefiningUse(..) | UsageKind::UnconstrainedHiddenType(..), |
| 68 | + UsageKind::UnconstrainedHiddenType(..) | UsageKind::HasDefiningUse, |
| 69 | + ) => *self = other, |
| 70 | + } |
| 71 | + } |
| 72 | +} |
| 73 | + |
| 74 | +impl<'tcx> FnCtxt<'_, 'tcx> { |
| 75 | + fn compute_concrete_opaque_types( |
| 76 | + &mut self, |
| 77 | + opaque_types: &[(OpaqueTypeKey<'tcx>, OpaqueHiddenType<'tcx>)], |
| 78 | + ) { |
| 79 | + let tcx = self.tcx; |
| 80 | + let TypingMode::Analysis { defining_opaque_types_and_generators } = self.typing_mode() |
| 81 | + else { |
| 82 | + unreachable!(); |
| 83 | + }; |
| 84 | + |
| 85 | + for def_id in defining_opaque_types_and_generators { |
| 86 | + match tcx.def_kind(def_id) { |
| 87 | + DefKind::OpaqueTy => {} |
| 88 | + DefKind::Closure => continue, |
| 89 | + _ => unreachable!("not opaque or generator: {def_id:?}"), |
| 90 | + } |
| 91 | + |
| 92 | + let mut usage_kind = UsageKind::None; |
| 93 | + for &(opaque_type_key, hidden_type) in opaque_types { |
| 94 | + if opaque_type_key.def_id != def_id { |
| 95 | + continue; |
| 96 | + } |
| 97 | + |
| 98 | + usage_kind.merge(self.consider_opaque_type_use(opaque_type_key, hidden_type)); |
| 99 | + if let UsageKind::HasDefiningUse = usage_kind { |
| 100 | + break; |
| 101 | + } |
| 102 | + } |
| 103 | + |
| 104 | + let guar = match usage_kind { |
| 105 | + UsageKind::None => { |
| 106 | + if let Some(guar) = self.tainted_by_errors() { |
| 107 | + guar |
| 108 | + } else { |
| 109 | + self.tcx.dcx().emit_err(TaitForwardCompat2 { |
| 110 | + span: self |
| 111 | + .tcx |
| 112 | + .def_ident_span(self.body_id) |
| 113 | + .unwrap_or_else(|| self.tcx.def_span(self.body_id)), |
| 114 | + opaque_type_span: self.tcx.def_span(def_id), |
| 115 | + opaque_type: self.tcx.def_path_str(def_id), |
| 116 | + }) |
| 117 | + } |
| 118 | + } |
| 119 | + UsageKind::NonDefiningUse(hidden_type) => { |
| 120 | + tcx.dcx().span_err(hidden_type.span, "non-defining use in the defining scope") |
| 121 | + } |
| 122 | + UsageKind::UnconstrainedHiddenType(hidden_type) => { |
| 123 | + let infer_var = hidden_type |
| 124 | + .ty |
| 125 | + .walk() |
| 126 | + .filter_map(ty::GenericArg::as_term) |
| 127 | + .find(|term| term.is_infer()) |
| 128 | + .unwrap_or_else(|| hidden_type.ty.into()); |
| 129 | + self.err_ctxt() |
| 130 | + .emit_inference_failure_err( |
| 131 | + self.body_id, |
| 132 | + hidden_type.span, |
| 133 | + infer_var, |
| 134 | + TypeAnnotationNeeded::E0282, |
| 135 | + false, |
| 136 | + ) |
| 137 | + .emit() |
| 138 | + } |
| 139 | + UsageKind::HasDefiningUse => continue, |
| 140 | + }; |
| 141 | + |
| 142 | + self.typeck_results |
| 143 | + .borrow_mut() |
| 144 | + .concrete_opaque_types |
| 145 | + .insert(def_id, OpaqueHiddenType::new_error(tcx, guar)); |
| 146 | + self.set_tainted_by_errors(guar); |
| 147 | + } |
| 148 | + } |
| 149 | + |
| 150 | + fn consider_opaque_type_use( |
| 151 | + &mut self, |
| 152 | + opaque_type_key: OpaqueTypeKey<'tcx>, |
| 153 | + hidden_type: OpaqueHiddenType<'tcx>, |
| 154 | + ) -> UsageKind<'tcx> { |
| 155 | + if let Err(err) = opaque_type_has_defining_use_args( |
| 156 | + &self, |
| 157 | + opaque_type_key, |
| 158 | + hidden_type.span, |
| 159 | + DefiningScopeKind::HirTypeck, |
| 160 | + ) { |
| 161 | + match err { |
| 162 | + NonDefiningUseReason::AlreadyReported(guar) => { |
| 163 | + self.typeck_results.borrow_mut().concrete_opaque_types.insert( |
| 164 | + opaque_type_key.def_id, |
| 165 | + OpaqueHiddenType::new_error(self.tcx, guar), |
| 166 | + ); |
| 167 | + return UsageKind::HasDefiningUse; |
| 168 | + } |
| 169 | + _ => return UsageKind::NonDefiningUse(hidden_type), |
| 170 | + }; |
| 171 | + } |
| 172 | + |
| 173 | + // We ignore uses of the opaque if they have any inference variables |
| 174 | + // as this can frequently happen with recursive calls. |
| 175 | + // |
| 176 | + // See `tests/ui/traits/next-solver/opaques/universal-args-non-defining.rs`. |
| 177 | + if hidden_type.ty.has_non_region_infer() { |
| 178 | + return UsageKind::UnconstrainedHiddenType(hidden_type); |
| 179 | + } |
| 180 | + |
| 181 | + let cause = ObligationCause::misc(hidden_type.span, self.body_id); |
| 182 | + let at = self.at(&cause, self.param_env); |
| 183 | + let hidden_type = match solve::deeply_normalize(at, hidden_type) { |
| 184 | + Ok(hidden_type) => hidden_type, |
| 185 | + Err(errors) => { |
| 186 | + let guar = self.err_ctxt().report_fulfillment_errors(errors); |
| 187 | + OpaqueHiddenType::new_error(self.tcx, guar) |
| 188 | + } |
| 189 | + }; |
| 190 | + let hidden_type = hidden_type.remap_generic_params_to_declaration_params( |
| 191 | + opaque_type_key, |
| 192 | + self.tcx, |
| 193 | + DefiningScopeKind::HirTypeck, |
| 194 | + ); |
| 195 | + |
| 196 | + let prev = self |
| 197 | + .typeck_results |
| 198 | + .borrow_mut() |
| 199 | + .concrete_opaque_types |
| 200 | + .insert(opaque_type_key.def_id, hidden_type); |
| 201 | + assert!(prev.is_none()); |
| 202 | + UsageKind::HasDefiningUse |
| 203 | + } |
| 204 | + |
| 205 | + fn apply_computed_concrete_opaque_types( |
| 206 | + &mut self, |
| 207 | + opaque_types: &[(OpaqueTypeKey<'tcx>, OpaqueHiddenType<'tcx>)], |
| 208 | + ) { |
| 209 | + let tcx = self.tcx; |
| 210 | + for &(key, hidden_type) in opaque_types { |
| 211 | + let expected = |
| 212 | + *self.typeck_results.borrow_mut().concrete_opaque_types.get(&key.def_id).unwrap(); |
| 213 | + |
| 214 | + let expected = EarlyBinder::bind(expected.ty).instantiate(tcx, key.args); |
| 215 | + self.demand_eqtype(hidden_type.span, expected, hidden_type.ty); |
| 216 | + } |
| 217 | + } |
| 218 | + |
3 | 219 | /// We may in theory add further uses of an opaque after cloning the opaque
|
4 | 220 | /// types storage during writeback when computing the defining uses.
|
5 | 221 | ///
|
|
0 commit comments