wip

Author: JonathanBrouwer

compiler/rustc_attr_parsing/src/attributes/deprecation.rs

@@ -5,7 +5,7 @@ use rustc_span::{Span, Symbol, sym};
 
 use super::util::parse_version;
 use super::{AttributeOrder, OnDuplicate, SingleAttributeParser};
-use crate::context::MaybeWarn::Allow;
+use crate::context::MaybeWarn::{Allow, Warn};
 use crate::context::{AcceptContext, AllowedTargets, Stage};
 use crate::parser::ArgParser;
 use crate::session_diagnostics;
@@ -56,6 +56,7 @@ impl<S: Stage> SingleAttributeParser<S> for DeprecationParser {
         Allow(Target::Trait),
         Allow(Target::AssocTy),
         Allow(Target::Variant),
+        Warn(Target::Expression),
     ]);
     const TEMPLATE: AttributeTemplate = template!(
         Word,

compiler/rustc_attr_parsing/src/attributes/macro_attrs.rs

@@ -6,7 +6,7 @@ use rustc_span::{Span, Symbol, sym};
 use thin_vec::ThinVec;
 
 use crate::attributes::{AcceptMapping, AttributeParser, NoArgsAttributeParser, OnDuplicate};
-use crate::context::MaybeWarn::Allow;
+use crate::context::MaybeWarn::{Allow, Warn};
 use crate::context::{AcceptContext, AllowedTargets, FinalizeContext, Stage};
 use crate::parser::ArgParser;
 use crate::session_diagnostics;

compiler/rustc_attr_parsing/src/context.rs

@@ -59,7 +59,7 @@ use crate::attributes::traits::{
 };
 use crate::attributes::transparency::TransparencyParser;
 use crate::attributes::{AttributeParser as _, Combine, Single, WithoutArgs};
-use crate::context::MaybeWarn::Allow;
+use crate::context::MaybeWarn::{Allow, Warn};
 use crate::parser::{ArgParser, MetaItemParser, PathParser};
 use crate::session_diagnostics::{AttributeParseError, AttributeParseErrorReason, UnknownMetaItem};
 
@@ -657,6 +657,13 @@ impl AllowedTargets {
             AllowedTargets::AllowList(list) => list.contains(&Allow(target)),
         }
     }
+
+    pub(crate) fn is_warn(&self, target: Target) -> bool {
+        match self {
+            AllowedTargets::AllowAll => false,
+            AllowedTargets::AllowList(list) => list.contains(&Warn(target)),
+        }
+    }
 }
 
 #[derive(Debug, Eq, PartialEq)]
@@ -875,6 +882,7 @@ impl<'sess, S: Stage> AttributeParser<'sess, S> {
 
                         if self.stage.should_emit().should_emit()
                             && !accept.allowed_targets.is_allowed(target)
+                            && !accept.allowed_targets.is_warn(target)
                         {
                             self.dcx().span_delayed_bug(
                                 n.item.span(),