Stop redundantly base64 encoding bitmaps into bytestrings

Author: notriddle

src/librustdoc/html/render/search_index.rs

@@ -14,7 +14,6 @@ use serde::de::{self, Deserializer, Error as _};
 use serde::ser::{SerializeSeq, Serializer};
 use serde::{Deserialize, Serialize};
 use stringdex::internals as stringdex_internals;
-use stringdex::internals::decode::read_base64_from_bytes;
 use stringdex_internals::decode::RoaringBitmap;
 use thin_vec::ThinVec;
 use tracing::instrument;
@@ -140,10 +139,8 @@ impl SerializedSearchIndex {
                 column_name.as_bytes(),
                 column_path.clone(),
                 &mut |_id, item| {
-                    let mut decoded = Vec::new();
-                    read_base64_from_bytes(item, &mut decoded)?;
                     column.push(
-                        RoaringBitmap::from_bytes(&decoded)
+                        RoaringBitmap::from_bytes(item)
                             .map(|(bitmap, _)| bitmap.to_vec())
                             .unwrap_or_default(),
                     );
@@ -731,12 +728,7 @@ impl SerializedSearchIndex {
                         let mut buf = Vec::new();
                         stringdex_internals::encode::write_bitmap_to_bytes(&value, &mut buf)
                             .unwrap();
-                        let mut serialized_result = Vec::new();
-                        stringdex_internals::encode::write_base64_to_bytes(
-                            &buf,
-                            &mut serialized_result,
-                        );
-                        serialized_result
+                        buf
                     }
                 }),
             )

src/librustdoc/html/static/js/search.js

@@ -1751,22 +1751,20 @@ class DocSearch {
     }
 
     /**
-     * @param {number} id positive-numbered generic index (the AST uses negative-numbered ones)
+     * @param {number} id non-negative generic index
      * @returns {Promise<stringdex.RoaringBitmap>}
      */
     async getGenericInvertedIndex(id) {
         const gii = this.database.getData("generic_inverted_index");
         if (!gii) {
             return RoaringBitmap.empty();
         }
-        const encoded = this.utf8decoder.decode(
-            await gii.at(id),
-        );
-        if (encoded === "" || encoded === undefined || encoded === null) {
+        const encoded = await gii.at(id);
+        if (encoded === undefined || encoded === null || encoded.length === 0) {
             return RoaringBitmap.empty();
         }
 
-        return new RoaringBitmap(makeUint8ArrayFromBase64(encoded));
+        return new RoaringBitmap(encoded);
     }
 
     /**