Skip to content

Commit 2961b46

Browse files
committed
Move tidy step's {should,make}_run before run for consistency
1 parent 488e956 commit 2961b46

File tree

1 file changed

+9
-9
lines changed
  • src/bootstrap/src/core/build_steps/test

1 file changed

+9
-9
lines changed

src/bootstrap/src/core/build_steps/test/tidy.rs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,15 @@ impl Step for Tidy {
3232
const DEFAULT: bool = true;
3333
const ONLY_HOSTS: bool = true;
3434

35+
fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
36+
let default = run.builder.doc_tests != DocTests::Only;
37+
run.path("src/tools/tidy").default_condition(default)
38+
}
39+
40+
fn make_run(run: RunConfig<'_>) {
41+
run.builder.ensure(Tidy);
42+
}
43+
3544
/// Runs the `tidy` tool.
3645
///
3746
/// This tool in `src/tools` checks up on various bits and pieces of style and
@@ -115,13 +124,4 @@ HELP: to skip test's attempt to check tidiness, pass `--skip src/tools/tidy` to
115124
crate::exit!(1);
116125
}
117126
}
118-
119-
fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
120-
let default = run.builder.doc_tests != DocTests::Only;
121-
run.path("src/tools/tidy").default_condition(default)
122-
}
123-
124-
fn make_run(run: RunConfig<'_>) {
125-
run.builder.ensure(Tidy);
126-
}
127127
}

0 commit comments

Comments
 (0)