Skip to content

Commit 2ea2100

Browse files
committed
Print crate count for check::Rustc in snapshot tests
1 parent 2e4e0fc commit 2ea2100

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

src/bootstrap/src/core/build_steps/check.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,13 @@ impl Step for Rustc {
232232
}
233233

234234
fn metadata(&self) -> Option<StepMetadata> {
235-
Some(StepMetadata::check("rustc", self.target).built_by(self.build_compiler))
235+
let metadata = StepMetadata::check("rustc", self.target).built_by(self.build_compiler);
236+
let metadata = if self.crates.is_empty() {
237+
metadata
238+
} else {
239+
metadata.with_metadata(format!("({} crates)", self.crates.len()))
240+
};
241+
Some(metadata)
236242
}
237243
}
238244

src/bootstrap/src/core/builder/tests.rs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1515,7 +1515,7 @@ mod snapshot {
15151515
ctx.config("check")
15161516
.path("compiler")
15171517
.render_steps(), @r"
1518-
[check] rustc 0 <host> -> rustc 1 <host>
1518+
[check] rustc 0 <host> -> rustc 1 <host> (73 crates)
15191519
[check] rustc 0 <host> -> rustc 1 <host>
15201520
[check] rustc 0 <host> -> rustc_codegen_cranelift 1 <host>
15211521
[check] rustc 0 <host> -> rustc_codegen_gcc 1 <host>
@@ -1528,9 +1528,7 @@ mod snapshot {
15281528
insta::assert_snapshot!(
15291529
ctx.config("check")
15301530
.path("rustc")
1531-
.render_steps(), @r"
1532-
[check] rustc 0 <host> -> rustc 1 <host>
1533-
");
1531+
.render_steps(), @"[check] rustc 0 <host> -> rustc 1 <host> (1 crates)");
15341532
}
15351533

15361534
#[test]
@@ -1548,7 +1546,7 @@ mod snapshot {
15481546
.path("compiler")
15491547
.stage(1)
15501548
.render_steps(), @r"
1551-
[check] rustc 0 <host> -> rustc 1 <host>
1549+
[check] rustc 0 <host> -> rustc 1 <host> (73 crates)
15521550
[check] rustc 0 <host> -> rustc 1 <host>
15531551
[check] rustc 0 <host> -> rustc_codegen_cranelift 1 <host>
15541552
[check] rustc 0 <host> -> rustc_codegen_gcc 1 <host>
@@ -1566,7 +1564,7 @@ mod snapshot {
15661564
[build] llvm <host>
15671565
[build] rustc 0 <host> -> rustc 1 <host>
15681566
[build] rustc 1 <host> -> std 1 <host>
1569-
[check] rustc 1 <host> -> rustc 2 <host>
1567+
[check] rustc 1 <host> -> rustc 2 <host> (73 crates)
15701568
[check] rustc 1 <host> -> rustc 2 <host>
15711569
[check] rustc 1 <host> -> rustc_codegen_cranelift 2 <host>
15721570
[check] rustc 1 <host> -> rustc_codegen_gcc 2 <host>
@@ -1585,7 +1583,7 @@ mod snapshot {
15851583
[build] rustc 0 <host> -> rustc 1 <host>
15861584
[build] rustc 1 <host> -> std 1 <host>
15871585
[build] rustc 1 <host> -> std 1 <target1>
1588-
[check] rustc 1 <host> -> rustc 2 <target1>
1586+
[check] rustc 1 <host> -> rustc 2 <target1> (73 crates)
15891587
[check] rustc 1 <host> -> rustc 2 <target1>
15901588
[check] rustc 1 <host> -> Rustdoc 2 <target1>
15911589
[check] rustc 1 <host> -> rustc_codegen_cranelift 2 <target1>
@@ -1682,7 +1680,7 @@ mod snapshot {
16821680
.paths(&["library", "compiler"])
16831681
.args(&args)
16841682
.render_steps(), @r"
1685-
[check] rustc 0 <host> -> rustc 1 <host>
1683+
[check] rustc 0 <host> -> rustc 1 <host> (73 crates)
16861684
[check] rustc 0 <host> -> rustc 1 <host>
16871685
[check] rustc 0 <host> -> rustc_codegen_cranelift 1 <host>
16881686
[check] rustc 0 <host> -> rustc_codegen_gcc 1 <host>

0 commit comments

Comments
 (0)