clippy: uibless new test output

In a couple of cases, adjust the test file, because otherwise the file
produces:

```
error: failed to apply suggestions for tests/ui/iter_overeager_cloned.rs with rustfix
cannot replace slice of data that was already replaced
Add //@no-rustfix to the test file to ignore rustfix suggestions
```

Author: joshtriplett

src/tools/clippy/tests/ui/iter_overeager_cloned.fixed

@@ -13,13 +13,13 @@ fn main() {
 
     let _: Option<String> = vec.iter().chain(vec.iter()).next().cloned();
 
-    let _: usize = vec.iter().filter(|x| x == &"2").count();
+    let _: usize = vec.iter().filter(|x| x == "2").count();
 
     let _: Vec<_> = vec.iter().take(2).cloned().collect();
 
     let _: Vec<_> = vec.iter().skip(2).cloned().collect();
 
-    let _ = vec.iter().filter(|x| x == &"2").nth(2).cloned();
+    let _ = vec.iter().filter(|x| x == "2").nth(2).cloned();
 
     let _ = [Some(Some("str".to_string())), Some(Some("str".to_string()))]
         .iter()
@@ -46,7 +46,7 @@ fn main() {
         iter: impl Iterator<Item = &'a (&'a u32, String)> + 'a,
         target: String,
     ) -> impl Iterator<Item = (&'a u32, String)> + 'a {
-        iter.filter(move |&(&a, b)| a == 1 && b == &target).cloned()
+        iter.filter(move |&(&a, b)| a == 1 && b == target).cloned()
     }
 
     {
@@ -57,7 +57,7 @@ fn main() {
         }
 
         fn bar<'a>(iter: impl Iterator<Item = &'a S<'a>> + 'a, target: String) -> impl Iterator<Item = S<'a>> + 'a {
-            iter.filter(move |&S { a, b }| **a == 1 && b == &target).cloned()
+            iter.filter(move |&S { a, b }| **a == 1 && b == target).cloned()
         }
     }
 

src/tools/clippy/tests/ui/iter_overeager_cloned.rs

@@ -47,7 +47,7 @@ fn main() {
         iter: impl Iterator<Item = &'a (&'a u32, String)> + 'a,
         target: String,
     ) -> impl Iterator<Item = (&'a u32, String)> + 'a {
-        iter.cloned().filter(move |(&a, b)| a == 1 && b == &target)
+        iter.cloned().filter(move |(&a, b)| a == 1 && b == target)
     }
 
     {
@@ -58,7 +58,7 @@ fn main() {
         }
 
         fn bar<'a>(iter: impl Iterator<Item = &'a S<'a>> + 'a, target: String) -> impl Iterator<Item = S<'a>> + 'a {
-            iter.cloned().filter(move |S { a, b }| **a == 1 && b == &target)
+            iter.cloned().filter(move |S { a, b }| **a == 1 && b == target)
         }
     }
 

src/tools/clippy/tests/ui/iter_overeager_cloned.stderr

@@ -28,6 +28,17 @@ LL |     let _: usize = vec.iter().filter(|x| x == &"2").cloned().count();
    = note: `-D clippy::redundant-clone` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::redundant_clone)]`
 
+error: taken reference of right operand
+  --> tests/ui/iter_overeager_cloned.rs:16:42
+   |
+LL |     let _: usize = vec.iter().filter(|x| x == &"2").cloned().count();
+   |                                          ^^^^^----
+   |                                               |
+   |                                               help: use the right value directly: `"2"`
+   |
+   = note: `-D clippy::op-ref` implied by `-D warnings`
+   = help: to override `-D warnings` add `#[allow(clippy::op_ref)]`
+
 error: unnecessarily eager cloning of iterator items
   --> tests/ui/iter_overeager_cloned.rs:18:21
    |
@@ -52,6 +63,14 @@ LL |     let _ = vec.iter().filter(|x| x == &"2").cloned().nth(2);
    |                                             |
    |                                             help: try: `.nth(2).cloned()`
 
+error: taken reference of right operand
+  --> tests/ui/iter_overeager_cloned.rs:22:35
+   |
+LL |     let _ = vec.iter().filter(|x| x == &"2").cloned().nth(2);
+   |                                   ^^^^^----
+   |                                        |
+   |                                        help: use the right value directly: `"2"`
+
 error: unnecessarily eager cloning of iterator items
   --> tests/ui/iter_overeager_cloned.rs:24:13
    |
@@ -119,18 +138,18 @@ LL |         let _ = vec.iter().cloned().find(f);
 error: unnecessarily eager cloning of iterator items
   --> tests/ui/iter_overeager_cloned.rs:50:9
    |
-LL |         iter.cloned().filter(move |(&a, b)| a == 1 && b == &target)
-   |         ^^^^-------------------------------------------------------
+LL |         iter.cloned().filter(move |(&a, b)| a == 1 && b == target)
+   |         ^^^^------------------------------------------------------
    |             |
-   |             help: try: `.filter(move |&(&a, b)| a == 1 && b == &target).cloned()`
+   |             help: try: `.filter(move |&(&a, b)| a == 1 && b == target).cloned()`
 
 error: unnecessarily eager cloning of iterator items
   --> tests/ui/iter_overeager_cloned.rs:61:13
    |
-LL |             iter.cloned().filter(move |S { a, b }| **a == 1 && b == &target)
-   |             ^^^^------------------------------------------------------------
+LL |             iter.cloned().filter(move |S { a, b }| **a == 1 && b == target)
+   |             ^^^^-----------------------------------------------------------
    |                 |
-   |                 help: try: `.filter(move |&S { a, b }| **a == 1 && b == &target).cloned()`
+   |                 help: try: `.filter(move |&S { a, b }| **a == 1 && b == target).cloned()`
 
 error: unneeded cloning of iterator items
   --> tests/ui/iter_overeager_cloned.rs:65:13
@@ -164,5 +183,5 @@ LL |     let _ = vec.iter().cloned().any(|x| x.len() == 1);
    |                       |
    |                       help: try: `.any(|x| x.len() == 1)`
 
-error: aborting due to 19 previous errors
+error: aborting due to 21 previous errors
 

src/tools/clippy/tests/ui/op_ref.fixed

@@ -18,7 +18,7 @@ fn main() {
     let a = "a".to_string();
     let b = "a";
 
-    if b < &a {
+    if b < a {
         println!("OK");
     }
 

src/tools/clippy/tests/ui/op_ref.stderr

@@ -11,6 +11,14 @@ help: use the values directly
 LL |     let foo = 5 - 6;
    |               ~   ~
 
+error: taken reference of right operand
+  --> tests/ui/op_ref.rs:21:8
+   |
+LL |     if b < &a {
+   |        ^^^^--
+   |            |
+   |            help: use the right value directly: `a`
+
 error: taken reference of right operand
   --> tests/ui/op_ref.rs:58:13
    |
@@ -35,5 +43,5 @@ LL |         let _ = two + &three;
    |                       |
    |                       help: use the right value directly: `three`
 
-error: aborting due to 4 previous errors
+error: aborting due to 5 previous errors