Migrate the extra_checks check to diagnostics

Author: Kobzol

src/tools/tidy/src/extra_checks/mod.rs

@@ -24,6 +24,7 @@ use std::str::FromStr;
 use std::{fmt, fs, io};
 
 use crate::CiInfo;
+use crate::diagnostics::DiagCtx;
 
 mod rustdoc_js;
 
@@ -54,8 +55,10 @@ pub fn check(
     bless: bool,
     extra_checks: Option<&str>,
     pos_args: &[String],
-    bad: &mut bool,
+    diag_ctx: DiagCtx,
 ) {
+    let mut check = diag_ctx.start_check("extra_checks");
+
     if let Err(e) = check_impl(
         root_path,
         outdir,
@@ -68,7 +71,7 @@ pub fn check(
         extra_checks,
         pos_args,
     ) {
-        tidy_error!(bad, "{e}");
+        check.error(e);
     }
 }
 

src/tools/tidy/src/main.rs

@@ -170,20 +170,20 @@ fn main() {
             )
         };
         check!(unstable_book, &src_path, collected);
-        //
-        // check!(
-        //     extra_checks,
-        //     &root_path,
-        //     &output_directory,
-        //     &ci_info,
-        //     &librustdoc_path,
-        //     &tools_path,
-        //     &npm,
-        //     &cargo,
-        //     bless,
-        //     extra_checks,
-        //     pos_args
-        // );
+
+        check!(
+            extra_checks,
+            &root_path,
+            &output_directory,
+            &ci_info,
+            &librustdoc_path,
+            &tools_path,
+            &npm,
+            &cargo,
+            bless,
+            extra_checks,
+            pos_args
+        );
     });
 
     if diag_ctx.into_conclusion() {