no overflowing_literals in fmt::Display of integers

Author: pascaldekloe

library/core/src/fmt/num.rs

@@ -244,18 +244,17 @@ macro_rules! impl_Display {
 
                 // Format per four digits from the lookup table.
                 // Four digits need a 16-bit $unsigned or wider.
-                #[allow(overflowing_literals)]
-                #[allow(unused_comparisons)]
-                while remain > 999 {
+                while const { Self::MAX as u128 > 999 } && remain > 999.try_into().unwrap() {
                     // SAFETY: All of the decimals fit in buf due to MAX_DEC_N.
                     unsafe { core::hint::assert_unchecked(offset >= 4) }
                     // SAFETY: The offset counts down from its initial buf.len()
                     // without underflow due to the previous assertion.
                     unsafe { core::hint::assert_unchecked(offset <= buf.len()) }
                     offset -= 4;
 
-                    let quad = remain % 100_00;
-                    remain /= 100_00;
+                    let scale: Self = 100_00.try_into().unwrap();
+                    let quad = remain % scale;
+                    remain /= scale;
                     let pair1 = (quad / 100) as usize;
                     let pair2 = (quad % 100) as usize;
                     buf[offset + 0].write(DEC_DIGITS_LUT[pair1 * 2 + 0]);