report errors in the commit phase

Author: LorrensP-2158466

compiler/rustc_resolve/src/imports.rs

@@ -85,6 +85,17 @@ impl<'ra> ImportResolutionOutputs<'ra> {
                     for (ns, pending_binding) in import_bindings.into_iter_with() {
                         match pending_binding {
                             PendingBinding::Ready(Some(binding)) => {
+                                if binding.is_assoc_item()
+                                    && !r.tcx.features().import_trait_associated_functions()
+                                {
+                                    feature_err(
+                                        r.tcx.sess,
+                                        sym::import_trait_associated_functions,
+                                        import.span,
+                                        "`use` associated items of traits is unstable",
+                                    )
+                                    .emit();
+                                }
                                 r.define_binding_local(parent, *target, ns, binding);
                             }
                             PendingBinding::Ready(None) => {
@@ -105,6 +116,16 @@ impl<'ra> ImportResolutionOutputs<'ra> {
                         continue;
                     };
 
+                    if module.is_trait() && !r.tcx.features().import_trait_associated_functions() {
+                        feature_err(
+                            r.tcx.sess,
+                            sym::import_trait_associated_functions,
+                            import.span,
+                            "`use` associated items of traits is unstable",
+                        )
+                        .emit();
+                    }
+
                     module.glob_importers.borrow_mut().push(import);
 
                     for (binding, key, warn_ambiguity) in import_bindings {
@@ -984,17 +1005,6 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                 );
                 let pending_binding = match binding_result {
                     Ok(binding) => {
-                        if binding.is_assoc_item()
-                            && !this.tcx.features().import_trait_associated_functions()
-                        {
-                            feature_err(
-                                this.tcx.sess,
-                                sym::import_trait_associated_functions,
-                                import.span,
-                                "`use` associated items of traits is unstable",
-                            )
-                            .emit();
-                        }
                         // We need the `target`, `source` can be extracted.
                         let imported_binding = this.import(binding, import);
                         PendingBinding::Ready(Some(imported_binding))
@@ -1573,16 +1583,6 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
             return SideEffectBindings::None;
         };
 
-        if module.is_trait() && !self.tcx.features().import_trait_associated_functions() {
-            feature_err(
-                self.tcx.sess,
-                sym::import_trait_associated_functions,
-                import.span,
-                "`use` associated items of traits is unstable",
-            )
-            .emit();
-        }
-
         if module == import.parent_scope.module {
             return SideEffectBindings::None;
         }