WIP

Author: JonathanBrouwer

compiler/rustc_ast_lowering/src/item.rs

@@ -994,7 +994,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
         let (defaultness, _) = self.lower_defaultness(i.kind.defaultness(), has_value);
         let hir_id = hir::HirId::make_owner(self.current_hir_id_owner.def_id);
         let attrs =
-            self.lower_attrs(hir_id, &i.attrs, i.span, Target::Impl { of_trait: is_in_trait_impl });
+            self.lower_attrs(hir_id, &i.attrs, i.span, Target::from_ast_item()); //TODO this is not correct
 
         let (ident, (generics, kind)) = match &i.kind {
             AssocItemKind::Const(box ConstItem {

compiler/rustc_attr_parsing/src/attributes/macro_attrs.rs

@@ -110,7 +110,7 @@ impl<S: Stage> AttributeParser<S> for MacroUseParser {
             }
         },
     )];
-    const ALLOWED_TARGETS: &'static [Target] = &[Target::Mod, Target::ExternCrate, Target::Crate]; //TODO crate?
+    const ALLOWED_TARGETS: &'static [Target] = &[Target::Mod, Target::ExternCrate];
 
     fn finalize(self, _cx: &FinalizeContext<'_, '_, S>) -> Option<AttributeKind> {
         Some(AttributeKind::MacroUse { span: self.first_span?, arguments: self.state })

compiler/rustc_attr_parsing/src/attributes/path.rs

@@ -13,7 +13,7 @@ impl<S: Stage> SingleAttributeParser<S> for PathParser {
     const PATH: &[Symbol] = &[sym::path];
     const ATTRIBUTE_ORDER: AttributeOrder = AttributeOrder::KeepOutermost;
     const ON_DUPLICATE: OnDuplicate<S> = OnDuplicate::WarnButFutureError;
-    const ALLOWED_TARGETS: &'static [Target] = &[Target::Use];
+    const ALLOWED_TARGETS: &'static [Target] = &[Target::Mod];
     const TEMPLATE: AttributeTemplate = template!(NameValueStr: "file");
 
     fn convert(cx: &mut AcceptContext<'_, '_, S>, args: &ArgParser<'_>) -> Option<AttributeKind> {

compiler/rustc_attr_parsing/src/attributes/stability.rs

@@ -30,7 +30,12 @@ const ALLOWED_TARGETS: &[Target] = &[Target::Fn,
     Target::Struct,
     Target::Method(MethodKind::Inherent),
     Target::Impl { of_trait: true },
-    Target::MacroDef];
+    Target::MacroDef,
+    Target::Crate,
+    Target::Mod,
+    Target::Use,
+    Target::Const
+];
 
 #[derive(Default)]
 pub(crate) struct StabilityParser {

compiler/rustc_attr_parsing/src/context.rs

@@ -851,7 +851,11 @@ impl<'sess, S: Stage> AttributeParser<'sess, S> {
 
                         (accept.accept_fn)(&mut cx, args);
 
-                        if !accept.allowed_targets.contains(&target) {
+                        if self.stage.should_emit().should_emit() && !accept.allowed_targets.contains(&target) {
+                            if parts == &[sym::unstable] && target == (Target::Impl { of_trait: false}) {
+                                panic!();
+                            }
+
                             self.dcx().span_bug(n.item.span(), format!("{:?} target {target:?} not allowed {:?}", parts, accept.allowed_targets));
                         }
                     } else {