Install yarn in nodejs.sh script instead of dockerfile so that it's present on all CI images

Author: yotamofek

src/ci/docker/host-x86_64/tidy/Dockerfile

@@ -29,7 +29,6 @@ RUN sh /scripts/nodejs.sh /node
 ENV PATH="/node/bin:${PATH}"
 
 COPY host-x86_64/tidy/eslint.version /tmp/
-COPY host-x86_64/tidy/yarn.version /tmp/
 
 COPY scripts/sccache.sh /scripts/
 RUN sh /scripts/sccache.sh
@@ -40,8 +39,7 @@ RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-require
 
 COPY host-x86_64/pr-check-1/validate-toolstate.sh /scripts/
 
-# Install yarn, and then use it to install eslint
-RUN bash -c 'npm install -g yarn@$(cat /tmp/yarn.version)'
+# Install eslint
 RUN bash -c 'yarn global add eslint@$(cat /tmp/eslint.version)'
 
 # NOTE: intentionally uses python2 for x.py so we can test it still works.

src/ci/docker/scripts/nodejs.sh

@@ -3,8 +3,13 @@
 set -ex
 
 NODEJS_VERSION=v20.12.2
+YARN_VERSION=1.22.22
 INSTALL_PATH=${1:-/node}
 
 url="https://nodejs.org/dist/${NODEJS_VERSION}/node-${NODEJS_VERSION}-linux-x64.tar.xz"
 curl -sL "$url" | tar -xJ
 mv node-${NODEJS_VERSION}-linux-x64 "${INSTALL_PATH}"
+
+# now, install yarn.
+# we call npm through the node binary, because otherwise npm will expect node to be in the PATH
+"${INSTALL_PATH}/bin/node" "${INSTALL_PATH}/bin/npm" install --global yarn@${YARN_VERSION}