Apply suggestions from code review

Co-authored-by: Sky <[email protected]>

Author: TimTheBig

library/alloc/src/bstr.rs

@@ -213,7 +213,6 @@ impl Default for ByteString {
 
 #[unstable(feature = "bstr", issue = "134915")]
 impl From<ByteString> for Vec<u8> {
-    /// Return the inner `Vec` of the byte string.
     #[inline]
     fn from(s: ByteString) -> Self {
         s.0

library/core/src/ptr/alignment.rs

@@ -197,7 +197,6 @@ impl From<Alignment> for NonZero<usize> {
 
 #[unstable(feature = "ptr_alignment_type", issue = "102070")]
 impl From<Alignment> for usize {
-    /// Return the inner value of `Alignment` as a `usize`.
     #[inline]
     fn from(align: Alignment) -> usize {
         align.as_usize()

library/core/src/range.rs

@@ -187,15 +187,13 @@ impl<T> IntoBounds<T> for Range<T> {
 
 #[unstable(feature = "new_range_api", issue = "125687")]
 impl<T> From<Range<T>> for legacy::Range<T> {
-    /// Make a new `legacy::Range` with the same start and end as `Range`
     #[inline]
     fn from(value: Range<T>) -> Self {
         Self { start: value.start, end: value.end }
     }
 }
 #[unstable(feature = "new_range_api", issue = "125687")]
 impl<T> From<legacy::Range<T>> for Range<T> {
-    /// Make a new `Range` with the same start and end as `legacy::Range`
     #[inline]
     fn from(value: legacy::Range<T>) -> Self {
         Self { start: value.start, end: value.end }
@@ -365,15 +363,13 @@ impl<T> IntoBounds<T> for RangeInclusive<T> {
 
 #[unstable(feature = "new_range_api", issue = "125687")]
 impl<T> From<RangeInclusive<T>> for legacy::RangeInclusive<T> {
-    /// Make a new `legacy::RangeInclusive` with the same start and end as `RangeInclusive`
     #[inline]
     fn from(value: RangeInclusive<T>) -> Self {
         Self::new(value.start, value.end)
     }
 }
 #[unstable(feature = "new_range_api", issue = "125687")]
 impl<T> From<legacy::RangeInclusive<T>> for RangeInclusive<T> {
-    /// Make a new `RangeInclusive` with the same start and end as `legacy::RangeInclusive`
     #[inline]
     fn from(value: legacy::RangeInclusive<T>) -> Self {
         assert!(
@@ -511,15 +507,13 @@ impl<T> IntoBounds<T> for RangeFrom<T> {
 
 #[unstable(feature = "new_range_api", issue = "125687")]
 impl<T> From<RangeFrom<T>> for legacy::RangeFrom<T> {
-    /// Make a new `legacy::RangeFrom` with the same start as `RangeFrom`
     #[inline]
     fn from(value: RangeFrom<T>) -> Self {
         Self { start: value.start }
     }
 }
 #[unstable(feature = "new_range_api", issue = "125687")]
 impl<T> From<legacy::RangeFrom<T>> for RangeFrom<T> {
-    /// Make a new `RangeFrom` with the same start as `legacy::RangeFrom`
     #[inline]
     fn from(value: legacy::RangeFrom<T>) -> Self {
         Self { start: value.start }

library/proc_macro/src/bridge/buffer.rs

@@ -127,8 +127,7 @@ impl Drop for Buffer {
 }
 
 impl From<Vec<u8>> for Buffer {
-    /// Create a `Buffer` without allocation.\
-    /// By moving data, len, and capacity from `Vec`, then create custom reserve and drop fns.
+    /// Create a `Buffer` without allocation.
     fn from(v: Vec<u8>) -> Self {
         let mut v = ManuallyDrop::new(v);
         let (data, len, capacity) = (v.as_mut_ptr(), v.len(), v.capacity());

library/std/src/os/fd/owned.rs

@@ -340,7 +340,6 @@ impl From<crate::net::TcpStream> for OwnedFd {
 #[stable(feature = "io_safety", since = "1.63.0")]
 #[cfg(not(target_os = "trusty"))]
 impl From<OwnedFd> for crate::net::TcpStream {
-    /// Create a `TcpStream` with a [`OwnedFd`] as inner.
     #[inline]
     fn from(owned_fd: OwnedFd) -> Self {
         Self::from_inner(FromInner::from_inner(FromInner::from_inner(FromInner::from_inner(
@@ -371,7 +370,6 @@ impl From<crate::net::TcpListener> for OwnedFd {
 #[stable(feature = "io_safety", since = "1.63.0")]
 #[cfg(not(target_os = "trusty"))]
 impl From<OwnedFd> for crate::net::TcpListener {
-    /// Create a `TcpListener` with a [`OwnedFd`] as inner.
     #[inline]
     fn from(owned_fd: OwnedFd) -> Self {
         Self::from_inner(FromInner::from_inner(FromInner::from_inner(FromInner::from_inner(
@@ -402,7 +400,6 @@ impl From<crate::net::UdpSocket> for OwnedFd {
 #[stable(feature = "io_safety", since = "1.63.0")]
 #[cfg(not(target_os = "trusty"))]
 impl From<OwnedFd> for crate::net::UdpSocket {
-    /// Create a `UdpSocket` with a [`OwnedFd`] as inner.
     #[inline]
     fn from(owned_fd: OwnedFd) -> Self {
         Self::from_inner(FromInner::from_inner(FromInner::from_inner(FromInner::from_inner(

library/std/src/os/linux/process.rs

@@ -131,7 +131,6 @@ impl AsFd for PidFd {
 }
 
 impl From<OwnedFd> for PidFd {
-    /// Make a `PidFd` from inner.
     fn from(fd: OwnedFd) -> Self {
         Self::from_inner(InnerPidFd::from_inner(FileDesc::from_inner(fd)))
     }

library/std/src/os/unix/net/listener.rs

@@ -342,7 +342,6 @@ impl AsFd for UnixListener {
 
 #[stable(feature = "io_safety", since = "1.63.0")]
 impl From<OwnedFd> for UnixListener {
-    /// Make a `UnixListener` with `OwnedFd` as it's file descriptor.
     #[inline]
     fn from(fd: OwnedFd) -> UnixListener {
         UnixListener(Socket::from_inner(FromInner::from_inner(fd)))

library/std/src/os/windows/io/socket.rs

@@ -320,7 +320,6 @@ impl From<crate::net::TcpStream> for OwnedSocket {
 
 #[stable(feature = "io_safety", since = "1.63.0")]
 impl From<OwnedSocket> for crate::net::TcpStream {
-    /// Make a `TcpStream` from [`OwnedSocket`]s underlying socket.
     #[inline]
     fn from(owned: OwnedSocket) -> Self {
         unsafe { Self::from_raw_socket(owned.into_raw_socket()) }
@@ -346,7 +345,6 @@ impl From<crate::net::TcpListener> for OwnedSocket {
 
 #[stable(feature = "io_safety", since = "1.63.0")]
 impl From<OwnedSocket> for crate::net::TcpListener {
-    /// Make a `TcpListener` from [`OwnedSocket`]s underlying socket.
     #[inline]
     fn from(owned: OwnedSocket) -> Self {
         unsafe { Self::from_raw_socket(owned.into_raw_socket()) }
@@ -372,7 +370,6 @@ impl From<crate::net::UdpSocket> for OwnedSocket {
 
 #[stable(feature = "io_safety", since = "1.63.0")]
 impl From<OwnedSocket> for crate::net::UdpSocket {
-    /// Make a `UdpSocket` from [`OwnedSocket`]s underlying socket.
     #[inline]
     fn from(owned: OwnedSocket) -> Self {
         unsafe { Self::from_raw_socket(owned.into_raw_socket()) }