Dont consider fields that are forced unstable due to -Zforce-unstable-if-unmarked to be uninhabited

Author: compiler-errors

compiler/rustc_middle/src/ty/inhabitedness/mod.rs

@@ -43,6 +43,7 @@
 //! This code should only compile in modules where the uninhabitedness of `Foo`
 //! is visible.
 
+use rustc_span::sym;
 use rustc_type_ir::TyKind::*;
 use tracing::instrument;
 
@@ -90,7 +91,13 @@ impl<'tcx> VariantDef {
                 //     `let pred = pred.or(InhabitedPredicate::IsUnstable(field.did));`
                 // but this is unnecessary for now, since it would only affect nightly-only
                 // code or code within the standard library itself.
-                if tcx.lookup_stability(field.did).is_some_and(|stab| stab.is_unstable()) {
+                // HACK: We filter out `rustc_private` fields since with the flag
+                // `-Zforce-unstable-if-unmarked` we consider all unmarked fields to be
+                // unstable when building the compiler.
+                if tcx
+                    .lookup_stability(field.did)
+                    .is_some_and(|stab| stab.is_unstable() && stab.feature != sym::rustc_private)
+                {
                     return InhabitedPredicate::True;
                 }
                 let pred = tcx.type_of(field.did).instantiate_identity().inhabited_predicate(tcx);

tests/ui/uninhabited/uninhabited-pin-field.rs

@@ -0,0 +1,10 @@
+use std::pin::Pin;
+
+enum Void {}
+
+fn demo(x: Pin<Void>) {
+    match x {}
+    //~^ ERROR non-exhaustive patterns
+}
+
+fn main() {}

tests/ui/uninhabited/uninhabited-pin-field.stderr

@@ -0,0 +1,19 @@
+error[E0004]: non-exhaustive patterns: type `Pin<Void>` is non-empty
+  --> $DIR/uninhabited-pin-field.rs:6:11
+   |
+LL |     match x {}
+   |           ^
+   |
+note: `Pin<Void>` defined here
+  --> $SRC_DIR/core/src/pin.rs:LL:COL
+   = note: the matched value is of type `Pin<Void>`
+help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern as shown
+   |
+LL ~     match x {
+LL +         _ => todo!(),
+LL ~     }
+   |
+
+error: aborting due to 1 previous error
+
+For more information about this error, try `rustc --explain E0004`.

tests/ui/uninhabited/uninhabited-unstable-field.stderr

@@ -14,7 +14,7 @@ help: ensure that all possible cases are being handled by adding a match arm wit
    |
 LL ~     match x {
 LL +         _ => todo!(),
-LL +     }
+LL ~     }
    |
 
 error: aborting due to 1 previous error