Check should_explore before insert

m-ysk · m-ysk · commit 47d326fe7720 · 2024-11-17T23:02:24.000+09:00
diff --git a/compiler/rustc_passes/src/dead.rs b/compiler/rustc_passes/src/dead.rs
@@ -265,7 +265,11 @@ impl<'tcx> MarkSymbolVisitor<'tcx> {
             }
             self.insert_def_id(variant.fields[FieldIdx::from_usize(idx)].did);
         }
-        self.insert_def_id(variant.def_id);
+        if let Some(def_id) = variant.def_id.as_local() {
+            if should_explore(self.tcx, def_id) {
+                self.insert_def_id(variant.def_id);
+            }
+        }
     }
 
     fn handle_offset_of(&mut self, expr: &'tcx hir::Expr<'tcx>) {

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,11 @@ impl<'tcx> MarkSymbolVisitor<'tcx> {`
`265`	`265`	`}`
`266`	`266`	`self.insert_def_id(variant.fields[FieldIdx::from_usize(idx)].did);`
`267`	`267`	`}`
`268`		`- self.insert_def_id(variant.def_id);`
	`268`	`+ if let Some(def_id) = variant.def_id.as_local() {`
	`269`	`+ if should_explore(self.tcx, def_id) {`
	`270`	`+ self.insert_def_id(variant.def_id);`
	`271`	`+ }`
	`272`	`+ }`
`269`	`273`	`}`
`270`	`274`
`271`	`275`	`fn handle_offset_of(&mut self, expr: &'tcx hir::Expr<'tcx>) {`