Apply suggestions from code review

scottmcm · oli-obk · web-flow · commit 4d7312683299 · 2024-12-08T05:26:19.000Z
Co-authored-by: Oli Scherer &lt;github35764891676564198441@oli-obk.de&gt;
diff --git a/compiler/rustc_mir_transform/src/gvn.rs b/compiler/rustc_mir_transform/src/gvn.rs
@@ -1460,8 +1460,8 @@ impl<'body, 'tcx> VnState<'body, 'tcx> {
             }
         }
 
-        // PtrToPtr-then-Transmute can just transmute the original, so long as the
-        // PtrToPtr didn't change metadata (and thus the size of the pointer)
+        // Transmute-then-PtrToPtr can just transmute the original, so long as the
+        // PtrToPtr won't change metadata (and thus the size of the pointer)
         if let PtrToPtr = kind
             && let Value::Cast {
                 kind: Transmute,

Original file line number	Diff line number	Diff line change
`@@ -1460,8 +1460,8 @@ impl<'body, 'tcx> VnState<'body, 'tcx> {`
`1460`	`1460`	`}`
`1461`	`1461`	`}`
`1462`	`1462`
`1463`		`- // PtrToPtr-then-Transmute can just transmute the original, so long as the`
`1464`		`- // PtrToPtr didn't change metadata (and thus the size of the pointer)`
	`1463`	`+ // Transmute-then-PtrToPtr can just transmute the original, so long as the`
	`1464`	`+ // PtrToPtr won't change metadata (and thus the size of the pointer)`
`1465`	`1465`	`if let PtrToPtr = kind`
`1466`	`1466`	`&& let Value::Cast {`
`1467`	`1467`	`kind: Transmute,`