Skip to content

Commit 51c15fa

Browse files
committed
Ignore test issue-45696-scribble-on-boxed-borrow.rs in Polonius compare mode
Once again, the difference is in the test construction, it is ignored in compare-mode NLL and tested manually with revisions, and fails because the `migrate` revision is ran with `-Zpolonius`. There is no actual difference in the errors output by NLLs and Polonius.
1 parent 63c837e commit 51c15fa

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

src/test/ui/issues/issue-45696-scribble-on-boxed-borrow.migrate.stderr

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
warning[E0713]: borrow may still be in use when destructor runs
2-
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:51:5
2+
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:52:5
33
|
44
LL | fn scribbled<'a>(s: Scribble<'a>) -> &'a mut u32 {
55
| -- lifetime `'a` defined here
@@ -14,7 +14,7 @@ LL | }
1414
= note: for more information, try `rustc --explain E0729`
1515

1616
warning[E0713]: borrow may still be in use when destructor runs
17-
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:62:5
17+
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:63:5
1818
|
1919
LL | fn boxed_scribbled<'a>(s: Box<Scribble<'a>>) -> &'a mut u32 {
2020
| -- lifetime `'a` defined here
@@ -29,7 +29,7 @@ LL | }
2929
= note: for more information, try `rustc --explain E0729`
3030

3131
warning[E0713]: borrow may still be in use when destructor runs
32-
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:73:5
32+
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:74:5
3333
|
3434
LL | fn boxed_boxed_scribbled<'a>(s: Box<Box<Scribble<'a>>>) -> &'a mut u32 {
3535
| -- lifetime `'a` defined here
@@ -44,7 +44,7 @@ LL | }
4444
= note: for more information, try `rustc --explain E0729`
4545

4646
error: compilation successful
47-
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:80:1
47+
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:81:1
4848
|
4949
LL | / fn main() {
5050
LL | | let mut x = 1;

src/test/ui/issues/issue-45696-scribble-on-boxed-borrow.nll.stderr

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
error[E0713]: borrow may still be in use when destructor runs
2-
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:51:5
2+
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:52:5
33
|
44
LL | fn scribbled<'a>(s: Scribble<'a>) -> &'a mut u32 {
55
| -- lifetime `'a` defined here
@@ -10,7 +10,7 @@ LL | }
1010
| - here, drop of `s` needs exclusive access to `*s.0`, because the type `Scribble<'_>` implements the `Drop` trait
1111

1212
error[E0713]: borrow may still be in use when destructor runs
13-
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:62:5
13+
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:63:5
1414
|
1515
LL | fn boxed_scribbled<'a>(s: Box<Scribble<'a>>) -> &'a mut u32 {
1616
| -- lifetime `'a` defined here
@@ -21,7 +21,7 @@ LL | }
2121
| - here, drop of `s` needs exclusive access to `*s.0`, because the type `Scribble<'_>` implements the `Drop` trait
2222

2323
error[E0713]: borrow may still be in use when destructor runs
24-
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:73:5
24+
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:74:5
2525
|
2626
LL | fn boxed_boxed_scribbled<'a>(s: Box<Box<Scribble<'a>>>) -> &'a mut u32 {
2727
| -- lifetime `'a` defined here

src/test/ui/issues/issue-45696-scribble-on-boxed-borrow.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
// revisions: nll migrate
99
// ignore-compare-mode-nll
10+
// ignore-compare-mode-polonius
1011

1112
// This test is going to pass in the migrate revision, because the AST-borrowck
1213
// accepted this code in the past (see notes below). So we use `#[rustc_error]`

0 commit comments

Comments
 (0)