address review

Author: LorrensP-2158466

src/tools/miri/src/math.rs

@@ -217,8 +217,6 @@ where
 
         // atan2(x, ±0) = −π/2 for x < 0.
         // atan2(x, ±0) =  π/2 for x > 0.
-        // REVIEW: Above is from C23, do we simplify this to the following?
-        // atan2(±x, 0) = ±π/2 if x is non-zero
         ("atan2f" | "atan2", [x, y]) if !x.is_zero() && y.is_zero() => pi_over_2.copy_sign(*x),
 
         //atan2(±∞, −∞) = ±3π/4
@@ -286,7 +284,7 @@ where
 }
 
 /// Returns `Some(output)` if `scalbn` (called `ldexp` in C) results in a fixed value specified in the
-/// C standard (specifically, C23 annex F.10.3.19) when doing `arg`*(2^`exp`). Otherwise, returns `None`.
+/// C standard (specifically, C23 annex F.10.3.19) when doing `arg*(2^exp)`. Otherwise, returns `None`.
 pub(crate) fn fixed_scalbn_value<S: Semantics>(
     arg: IeeeFloat<S>,
     exp: i32,
@@ -399,7 +397,6 @@ pub trait IeeeExt: rustc_apfloat::Float {
         Self::from_u128(3).value
     }
 
-    /// Equal PI.
     fn pi() -> Self;
 
     #[inline]
@@ -413,6 +410,7 @@ macro_rules! impl_ieee_pi {
         impl IeeeExt for IeeeFloat<$semantic> {
             #[inline]
             fn pi() -> Self {
+                // We take the value from the standard library as the most reasonable source for an exact π here.
                 Self::from_bits($float_ty::consts::PI.to_bits() as _)
             }
         }

src/tools/miri/tests/pass/float.rs

@@ -1481,7 +1481,6 @@ fn test_non_determinism() {
     }
     pub fn test_operations_f32(a: f32, b: f32) {
         test_operations_f!(a, b);
-        // FIXME: some are temporarily disabled as it breaks std tests.
         ensure_nondet(|| a.powf(b));
         ensure_nondet(|| a.powi(2));
         ensure_nondet(|| a.log(b));
@@ -1518,7 +1517,6 @@ fn test_non_determinism() {
     }
     pub fn test_operations_f64(a: f64, b: f64) {
         test_operations_f!(a, b);
-        // FIXME: some are temporarily disabled as it breaks std tests.
         ensure_nondet(|| a.powf(b));
         ensure_nondet(|| a.powi(2));
         ensure_nondet(|| a.log(b));