delete no_mangle from ui/panic-handler/panic-handler-wrong-location test

Author: alexandruradovici

compiler/rustc_codegen_ssa/src/codegen_attrs.rs

@@ -620,7 +620,7 @@ fn codegen_fn_attrs(tcx: TyCtxt<'_>, did: LocalDefId) -> CodegenFnAttrs {
                 // This should never use the default as `no_mangle` is present in the attributes list
                 let no_mangle_span = no_mangle_span.unwrap_or_default();
                 let label_attr = format!("this defines it as the `{}` item", lang_item.name());
-                let label = format!("is the {} item", lang_item.name());
+                let label = format!("should be the {} item", lang_item.name());
                 let mut err = tcx.dcx()
                     .struct_span_err(no_mangle_span, "`#[no_mangle]` cannot be used on weak language items")
                     .with_note("The linker requires specific names for internal language items,")
@@ -642,7 +642,7 @@ fn codegen_fn_attrs(tcx: TyCtxt<'_>, did: LocalDefId) -> CodegenFnAttrs {
                 // This should never use the default as `no_mangle` is present in the attributes list
                 let no_mangle_span = no_mangle_span.unwrap_or_default();
                 let label_attr = format!("this defines it as the `{}` item", lang_item.name());
-                let label = format!("is the {} item", lang_item.name());
+                let label = format!("should be the {} item", lang_item.name());
                 let mut warn = tcx
                     .dcx()
                     .struct_span_warn(

tests/ui/codegen/no_mangle_on_std_internal_lang_items.rs renamed to tests/ui/codegen/no-mangle-on-std-internal-lang-items.rs

@@ -1,18 +1,18 @@
 warning: `#[no_mangle]` should not be used on std internal language items
-  --> $DIR/no_mangle_on_std_internal_lang_items.rs:11:1
+  --> $DIR/no-mangle-on-std-internal-lang-items.rs:11:1
    |
 LL | #[lang = "start"]
    | ----------------- this defines it as the `start` item
 LL | #[unsafe(no_mangle)]
    | ^^^^^^^^^^^^^^^^^^^^
 LL | fn my_custom_start<T>(main: fn() -> T, _argc: isize, _argv: *const *const u8, _arg: u8) -> isize {
-   | ------------------------------------------------------------------------------------------------ is the start item
+   | ------------------------------------------------------------------------------------------------ should be the start item
    |
    = note: The linker requires specific names for internal language items,
    = note: as they might require a specific link name in the future.
 
 warning: functions generic over types or consts must be mangled
-  --> $DIR/no_mangle_on_std_internal_lang_items.rs:12:1
+  --> $DIR/no-mangle-on-std-internal-lang-items.rs:12:1
    |
 LL |   #[unsafe(no_mangle)]
    |   -------------------- help: remove this attribute

tests/ui/codegen/no_mangle_on_std_internal_lang_items.stderr renamed to tests/ui/codegen/no-mangle-on-std-internal-lang-items.stderr

@@ -1,15 +1,18 @@
 error: `#[no_mangle]` cannot be used on weak language items
-  --> $DIR/no_mangle_on_weak_lang_items.rs:10:1
+  --> $DIR/no-mangle-on-weak-lang-items.rs:10:1
    |
 LL | #[unsafe(no_mangle)]
    | ^^^^^^^^^^^^^^^^^^^^
 LL | #[panic_handler]
    | ---------------- this defines it as the `panic_impl` item
 LL | pub unsafe fn panic_fmt(pi: &PanicInfo) -> ! {
-   | -------------------------------------------- is the panic_impl item
+   | -------------------------------------------- should be the panic_impl item
    |
    = note: The linker requires specific names for internal language items,
    = note: like panic handlers, eh personality functions or eh catch typeinfo variables.
+   = note: If you are trying to prevent mangling to ease debugging, many
+   = note: debuggers support a command such as `rbreak {sym}` to
+   = note: match `.*{sym}.*` instead of `break {sym}` on a specific name
    = note: In this case it is automatically renamed to `rust_begin_unwind`
 
 error: aborting due to 1 previous error

tests/ui/codegen/no_mangle_on_weak_lang_items.rs renamed to tests/ui/codegen/no-mangle-on-weak-lang-items.rs

@@ -4,7 +4,6 @@
 #![no_main]
 
 #[panic_handler] //~ ERROR `panic_impl` lang item must be applied to a function
-#[no_mangle]
 static X: u32 = 42;
 
 //~? ERROR `#[panic_handler]` function required, but not found