Skip to content

Commit 752048a

Browse files
committed
Handle more fallout
os::args() no longer auto-borrows to &[~str].
1 parent fa82ef2 commit 752048a

17 files changed

+24
-11
lines changed

src/librustc/front/test.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ mod __test {
282282
#![!resolve_unexported]
283283
extern crate test (name = "test", vers = "...");
284284
fn main() {
285-
test::test_main_static(::os::args(), tests)
285+
test::test_main_static(::os::args().as_slice(), tests)
286286
}
287287
288288
static tests : &'static [test::TestDescAndFn] = &[
@@ -326,8 +326,8 @@ fn mk_test_module(cx: &TestCtxt) -> @ast::Item {
326326
let mainfn = (quote_item!(&cx.ext_cx,
327327
pub fn main() {
328328
#![main]
329-
#![allow(deprecated_owned_vector)]
330-
test::test_main_static(::std::os::args(), TESTS);
329+
use std::slice::Vector;
330+
test::test_main_static(::std::os::args().as_slice(), TESTS);
331331
}
332332
)).unwrap();
333333

src/librustdoc/html/format.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ impl fmt::Show for clean::Type {
380380
"".to_owned()
381381
} else {
382382
let mut m = decl.bounds.iter().map(|s| s.to_str());
383-
": " + m.collect::<~[~str]>().connect(" + ")
383+
": " + m.collect::<Vec<~str>>().connect(" + ")
384384
},
385385
arrow = match decl.decl.output { clean::Unit => "no", _ => "yes" },
386386
ret = decl.decl.output)

src/librustdoc/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ local_data_key!(pub analysiskey: core::CrateAnalysis)
8585
type Output = (clean::Crate, Vec<plugins::PluginJson> );
8686

8787
pub fn main() {
88-
std::os::set_exit_status(main_args(std::os::args()));
88+
std::os::set_exit_status(main_args(std::os::args().as_slice()));
8989
}
9090

9191
pub fn opts() -> Vec<getopts::OptGroup> {

src/libstd/lib.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,4 +278,7 @@ mod std {
278278
pub use ty;
279279
pub use unstable;
280280
pub use vec;
281+
282+
// The test runner requires std::slice::Vector, so re-export std::slice just for it.
283+
#[cfg(test)] pub use slice;
281284
}

src/test/run-make/unicode-input/multiple_files.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ fn random_char() -> char {
3636

3737
fn main() {
3838
let args = os::args();
39-
let rustc = args[1].as_slice();
40-
let tmpdir = Path::new(args[2].as_slice());
39+
let rustc = args.get(1).as_slice();
40+
let tmpdir = Path::new(args.get(2).as_slice());
4141

4242
let main_file = tmpdir.join("unicode_input_multiple_files_main.rs");
4343
let main_file_str = main_file.as_str().unwrap();

src/test/run-make/unicode-input/span_length.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ fn random_char() -> char {
3535

3636
fn main() {
3737
let args = os::args();
38-
let rustc = args[1].as_slice();
39-
let tmpdir = Path::new(args[2].as_slice());
38+
let rustc = args.get(1).as_slice();
39+
let tmpdir = Path::new(args.get(2).as_slice());
4040

4141
let main_file = tmpdir.join("span_main.rs");
4242
let main_file_str = main_file.as_str().unwrap();

src/test/run-pass/backtrace.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ fn runtest(me: &str) {
100100

101101
fn main() {
102102
let args = os::args();
103+
let args = args.as_slice();
103104
if args.len() >= 2 && args[1].as_slice() == "fail" {
104105
foo();
105106
} else if args.len() >= 2 && args[1].as_slice() == "double-fail" {

src/test/run-pass/cleanup-shortcircuit.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ use std::os;
2424

2525
pub fn main() {
2626
let args = os::args();
27+
let args = args.as_slice();
2728

2829
// Here, the rvalue `"signal".to_owned()` requires cleanup. Older versions
2930
// of the code had a problem that the cleanup scope for this

src/test/run-pass/issue-10626.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ use std::io::process;
1717

1818
pub fn main () {
1919
let args = os::args();
20+
let args = args.as_slice();
2021
if args.len() > 1 && args[1] == "child".to_owned() {
2122
for _ in range(0, 1000) {
2223
println!("hello?");

src/test/run-pass/issue-13304.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ fn start(argc: int, argv: **u8) -> int {
2525

2626
fn main() {
2727
let args = os::args();
28+
let args = args.as_slice();
2829
if args.len() > 1 && args[1].as_slice() == "child" {
2930
if args[2].as_slice() == "green" {
3031
child();
@@ -48,6 +49,7 @@ fn main() {
4849

4950
fn parent(flavor: ~str) {
5051
let args = os::args();
52+
let args = args.as_slice();
5153
let mut p = io::Process::new(args[0].as_slice(), ["child".to_owned(), flavor]).unwrap();
5254
p.stdin.get_mut_ref().write_str("test1\ntest2\ntest3").unwrap();
5355
let out = p.wait_with_output();

0 commit comments

Comments
 (0)