review comment: reword message and add detail to tests

Author: estebank

compiler/rustc_const_eval/messages.ftl

@@ -104,15 +104,15 @@ const_eval_frame_note = {$times ->
 }
 
 const_eval_frame_note_inner = {$is_last ->
-    [true] {"the evaluated program failed "}
+    [true] {"the failure occurred "}
     *[false] {""}
     }inside {$where_ ->
     [closure] closure
     [instance] `{$instance}`
     *[other] {""}
 }
 
-const_eval_frame_note_last = the evaluated program failed here
+const_eval_frame_note_last = the failure occurred here
 
 const_eval_in_bounds_test = out-of-bounds pointer use
 const_eval_incompatible_calling_conventions =

tests/ui/borrowck/issue-81899.rs

@@ -8,7 +8,7 @@ const fn f<F>(_: &[u8], _: F) -> &[u8]
 where
     F: FnMut(&u8),
 {
-    panic!() //~ panic
+    panic!() //~ inside `f
 }
 
 fn main() {}

tests/ui/borrowck/issue-81899.stderr

@@ -4,11 +4,11 @@ error[E0080]: evaluation of constant value failed
 LL | const _CONST: &[u8] = &f(&[], |_| {});
    |                        ^^^^^^^^^^^^^^ panic: explicit panic
    |
-note: the evaluated program failed inside `f::<{closure@$DIR/issue-81899.rs:4:31: 4:34}>`
+note: the failure occurred inside `f::<{closure@$DIR/issue-81899.rs:4:31: 4:34}>`
   --> $DIR/issue-81899.rs:11:5
    |
 LL |     panic!()
-   |     ^^^^^^^^ the evaluated program failed here
+   |     ^^^^^^^^ the failure occurred here
    = note: this error originates in the macro `$crate::panic::panic_2015` which comes from the expansion of the macro `panic` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 note: erroneous constant encountered

tests/ui/borrowck/issue-88434-minimal-example.rs

@@ -7,7 +7,7 @@ const fn f<F>(_: &F)
 where
     F: FnMut(&u8),
 {
-    panic!() //~ panic
+    panic!() //~ inside `f
 }
 
 fn main() { }

tests/ui/borrowck/issue-88434-minimal-example.stderr

@@ -4,11 +4,11 @@ error[E0080]: evaluation of constant value failed
 LL | const _CONST: &() = &f(&|_| {});
    |                      ^^^^^^^^^^ panic: explicit panic
    |
-note: the evaluated program failed inside `f::<{closure@$DIR/issue-88434-minimal-example.rs:3:25: 3:28}>`
+note: the failure occurred inside `f::<{closure@$DIR/issue-88434-minimal-example.rs:3:25: 3:28}>`
   --> $DIR/issue-88434-minimal-example.rs:10:5
    |
 LL |     panic!()
-   |     ^^^^^^^^ the evaluated program failed here
+   |     ^^^^^^^^ the failure occurred here
    = note: this error originates in the macro `$crate::panic::panic_2015` which comes from the expansion of the macro `panic` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 note: erroneous constant encountered

tests/ui/borrowck/issue-88434-removal-index-should-be-less.rs

@@ -7,7 +7,7 @@ const fn f<F>(_: &[u8], _: F) -> &[u8]
 where
     F: FnMut(&u8),
 {
-    panic!() //~ panic
+    panic!() //~ inside `f
 }
 
 fn main() { }

tests/ui/borrowck/issue-88434-removal-index-should-be-less.stderr

@@ -4,11 +4,11 @@ error[E0080]: evaluation of constant value failed
 LL | const _CONST: &[u8] = &f(&[], |_| {});
    |                        ^^^^^^^^^^^^^^ panic: explicit panic
    |
-note: the evaluated program failed inside `f::<{closure@$DIR/issue-88434-removal-index-should-be-less.rs:3:31: 3:34}>`
+note: the failure occurred inside `f::<{closure@$DIR/issue-88434-removal-index-should-be-less.rs:3:31: 3:34}>`
   --> $DIR/issue-88434-removal-index-should-be-less.rs:10:5
    |
 LL |     panic!()
-   |     ^^^^^^^^ the evaluated program failed here
+   |     ^^^^^^^^ the failure occurred here
    = note: this error originates in the macro `$crate::panic::panic_2015` which comes from the expansion of the macro `panic` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 note: erroneous constant encountered

tests/ui/coherence/const-errs-dont-conflict-103369.stderr

@@ -4,11 +4,11 @@ error[E0080]: evaluation of constant value failed
 LL | impl ConstGenericTrait<{my_fn(1)}> for () {}
    |                         ^^^^^^^^ panic: Some error occurred
    |
-note: the evaluated program failed inside `my_fn`
+note: the failure occurred inside `my_fn`
   --> $DIR/const-errs-dont-conflict-103369.rs:10:5
    |
 LL |     panic!("Some error occurred");
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the evaluated program failed here
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the failure occurred here
    = note: this error originates in the macro `$crate::panic::panic_2015` which comes from the expansion of the macro `panic` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 error[E0080]: evaluation of constant value failed
@@ -17,11 +17,11 @@ error[E0080]: evaluation of constant value failed
 LL | impl ConstGenericTrait<{my_fn(2)}> for () {}
    |                         ^^^^^^^^ panic: Some error occurred
    |
-note: the evaluated program failed inside `my_fn`
+note: the failure occurred inside `my_fn`
   --> $DIR/const-errs-dont-conflict-103369.rs:10:5
    |
 LL |     panic!("Some error occurred");
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the evaluated program failed here
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the failure occurred here
    = note: this error originates in the macro `$crate::panic::panic_2015` which comes from the expansion of the macro `panic` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 error: aborting due to 2 previous errors

tests/ui/const-generics/issues/issue-100313.rs

@@ -6,7 +6,7 @@ struct T<const B: &'static bool>;
 impl<const B: &'static bool> T<B> {
     const fn set_false(&self) {
         unsafe {
-            *(B as *const bool as *mut bool) = false;
+            *(B as *const bool as *mut bool) = false; //~ inside `T
         }
     }
 }

tests/ui/const-generics/issues/issue-100313.stderr

@@ -4,11 +4,11 @@ error[E0080]: evaluation of constant value failed
 LL |     x.set_false();
    |     ^^^^^^^^^^^^^ writing to ALLOC0 which is read-only
    |
-note: the evaluated program failed inside `T::<&true>::set_false`
+note: the failure occurred inside `T::<&true>::set_false`
   --> $DIR/issue-100313.rs:9:13
    |
 LL |             *(B as *const bool as *mut bool) = false;
-   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the evaluated program failed here
+   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the failure occurred here
 
 error: aborting due to 1 previous error