Commit 847c422
authored
Rollup merge of #147171 - Qelxiros:hashmap_diag, r=fee1-dead
recommend using a HashMap if a HashSet's second generic parameter doesn't implement BuildHasher
closes #147147
~The suggestion span is wrong, but I'm not sure how to find the right one.~ fixed
I'm relatively new to the diagnostics ecosystem, so I'm not sure if `span_help` is the right choice. `span_suggestion_*` might be better, but the output from `x test` looks weird in that case.File tree
5 files changed
+101
-8
lines changed- compiler
- rustc_hir_typeck/src/method
- rustc_span/src
- library/core/src/hash
- tests/ui/hashmap
5 files changed
+101
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1754 | 1754 | | |
1755 | 1755 | | |
1756 | 1756 | | |
| 1757 | + | |
| 1758 | + | |
| 1759 | + | |
| 1760 | + | |
| 1761 | + | |
| 1762 | + | |
| 1763 | + | |
| 1764 | + | |
| 1765 | + | |
| 1766 | + | |
| 1767 | + | |
| 1768 | + | |
| 1769 | + | |
| 1770 | + | |
1757 | 1771 | | |
1758 | 1772 | | |
1759 | 1773 | | |
| |||
2990 | 3004 | | |
2991 | 3005 | | |
2992 | 3006 | | |
2993 | | - | |
| 3007 | + | |
2994 | 3008 | | |
2995 | 3009 | | |
2996 | 3010 | | |
| |||
3000 | 3014 | | |
3001 | 3015 | | |
3002 | 3016 | | |
3003 | | - | |
| 3017 | + | |
3004 | 3018 | | |
3005 | 3019 | | |
3006 | 3020 | | |
3007 | 3021 | | |
3008 | 3022 | | |
3009 | 3023 | | |
3010 | 3024 | | |
3011 | | - | |
| 3025 | + | |
3012 | 3026 | | |
3013 | 3027 | | |
3014 | | - | |
| 3028 | + | |
3015 | 3029 | | |
3016 | 3030 | | |
3017 | 3031 | | |
| |||
3024 | 3038 | | |
3025 | 3039 | | |
3026 | 3040 | | |
3027 | | - | |
| 3041 | + | |
3028 | 3042 | | |
3029 | 3043 | | |
3030 | 3044 | | |
| |||
3033 | 3047 | | |
3034 | 3048 | | |
3035 | 3049 | | |
3036 | | - | |
| 3050 | + | |
3037 | 3051 | | |
3038 | 3052 | | |
3039 | 3053 | | |
| |||
3051 | 3065 | | |
3052 | 3066 | | |
3053 | 3067 | | |
3054 | | - | |
| 3068 | + | |
| 3069 | + | |
3055 | 3070 | | |
3056 | | - | |
| 3071 | + | |
3057 | 3072 | | |
3058 | 3073 | | |
3059 | 3074 | | |
| |||
3066 | 3081 | | |
3067 | 3082 | | |
3068 | 3083 | | |
| 3084 | + | |
| 3085 | + | |
| 3086 | + | |
| 3087 | + | |
| 3088 | + | |
| 3089 | + | |
| 3090 | + | |
| 3091 | + | |
| 3092 | + | |
| 3093 | + | |
| 3094 | + | |
3069 | 3095 | | |
3070 | 3096 | | |
3071 | 3097 | | |
| |||
4388 | 4414 | | |
4389 | 4415 | | |
4390 | 4416 | | |
| 4417 | + | |
| 4418 | + | |
| 4419 | + | |
| 4420 | + | |
| 4421 | + | |
| 4422 | + | |
| 4423 | + | |
| 4424 | + | |
| 4425 | + | |
| 4426 | + | |
| 4427 | + | |
| 4428 | + | |
| 4429 | + | |
| 4430 | + | |
| 4431 | + | |
| 4432 | + | |
4391 | 4433 | | |
4392 | 4434 | | |
4393 | 4435 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
| 194 | + | |
194 | 195 | | |
195 | 196 | | |
196 | 197 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
633 | 633 | | |
634 | 634 | | |
635 | 635 | | |
| 636 | + | |
636 | 637 | | |
637 | 638 | | |
638 | 639 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
0 commit comments