Addressed comments.

* use string slices instead of string
* fix the format.

Author: xingxue-ibm

compiler/rustc_codegen_ssa/src/back/link.rs

@@ -1107,13 +1107,23 @@ fn link_natively(
         let stripcmd = "rust-objcopy";
         match (strip, crate_type) {
             (Strip::Debuginfo, _) => {
-                let strip_options = vec!["-S".to_string()];
-                strip_symbols_with_external_utility(sess, stripcmd, out_filename, Some(&strip_options))
+                let strip_options = vec!["-S"];
+                strip_symbols_with_external_utility(
+                    sess,
+                    stripcmd,
+                    out_filename,
+                    Some(&strip_options),
+                )
             }
             // Per the manpage, `-x` is the maximum safe strip level for dynamic libraries. (#93988)
             (Strip::Symbols, CrateType::Dylib | CrateType::Cdylib | CrateType::ProcMacro) => {
-                let strip_options = vec!["-x".to_string()];
-                strip_symbols_with_external_utility(sess, stripcmd, out_filename, Some(&strip_options))
+                let strip_options = vec!["-x"];
+                strip_symbols_with_external_utility(
+                    sess,
+                    stripcmd,
+                    out_filename,
+                    Some(&strip_options),
+                )
             }
             (Strip::Symbols, _) => {
                 strip_symbols_with_external_utility(sess, stripcmd, out_filename, None)
@@ -1133,8 +1143,13 @@ fn link_natively(
         match strip {
             // Always preserve the symbol table (-x).
             Strip::Debuginfo => {
-                let strip_options = vec!["-x".to_string()];
-                strip_symbols_with_external_utility(sess, stripcmd, out_filename, Some(&strip_options))
+                let strip_options = vec!["-x"];
+                strip_symbols_with_external_utility(
+                    sess,
+                    stripcmd,
+                    out_filename,
+                    Some(&strip_options),
+                )
             }
             // Strip::Symbols is handled via the --strip-all linker option.
             Strip::Symbols => {}
@@ -1148,17 +1163,27 @@ fn link_natively(
             sess.dcx().emit_warn(errors::AixStripNotUsed);
         }
         let stripcmd = "/usr/bin/strip";
-        let mut strip_options = vec!["-X32_64".to_string()];
+        let mut strip_options = vec!["-X32_64"];
         match strip {
             Strip::Debuginfo => {
                 // FIXME: AIX's strip utility only offers option to strip line number information.
-                strip_options.push("-l".to_string());
-                strip_symbols_with_external_utility(sess, stripcmd, out_filename, Some(&strip_options))
+                strip_options.push("-l");
+                strip_symbols_with_external_utility(
+                    sess,
+                    stripcmd,
+                    out_filename,
+                    Some(&strip_options),
+                )
             }
             Strip::Symbols => {
                 // Must be noted this option might remove symbol __aix_rust_metadata and thus removes .info section which contains metadata.
-                strip_options.push("-r".to_string());
-                strip_symbols_with_external_utility(sess, stripcmd, out_filename, Some(&strip_options))
+                strip_options.push("-r");
+                strip_symbols_with_external_utility(
+                    sess,
+                    stripcmd,
+                    out_filename,
+                    Some(&strip_options),
+                )
             }
             Strip::None => {}
         }
@@ -1171,7 +1196,7 @@ fn strip_symbols_with_external_utility(
     sess: &Session,
     util: &str,
     out_filename: &Path,
-    options: Option<&[String]>,
+    options: Option<&[&str]>,
 ) {
     let mut cmd = Command::new(util);
     if let Some(opts) = options {