Iterate over params and minor fixes

Author: Sa4dUs

compiler/rustc_codegen_llvm/src/builder/gpu_offload.rs

@@ -390,8 +390,7 @@ pub(crate) fn gen_call_handling<'ll>(
     let mut vals = vec![];
     let mut geps = vec![];
     let i32_0 = cx.get_const_i32(0);
-    for index in 0..num_args {
-        let v = args[index as usize];
+    for &v in args {
         let gep = builder.inbounds_gep(cx.type_f32(), v, &[i32_0]);
         vals.push(v);
         geps.push(gep);

compiler/rustc_codegen_llvm/src/intrinsic.rs

@@ -199,7 +199,7 @@ impl<'ll, 'tcx> IntrinsicCallBuilderMethods<'tcx> for Builder<'_, 'll, 'tcx> {
                 return Ok(());
             }
             sym::offload => {
-                // FIXME(Sa4dUs): emit error when offload is not enabled
+                // TODO(Sa4dUs): emit error when offload is not enabled
                 codegen_offload(self, tcx, instance, args);
                 return Ok(());
             }

compiler/rustc_middle/src/ty/offload_meta.rs

@@ -86,19 +86,8 @@ impl MappingFlags {
             | ty::Adt(_, _)
             | ty::Tuple(_)
             | ty::Array(_, _)
-            | ty::FnDef(_, _)
-            | ty::FnPtr(_, _)
-            | ty::Closure(_, _)
-            | ty::CoroutineClosure(_, _)
-            | ty::Coroutine(_, _)
-            | ty::CoroutineWitness(_, _)
-            | ty::Never
             | ty::Alias(_, _)
-            | ty::Param(_)
-            | ty::Bound(_, _)
-            | ty::Placeholder(_)
-            | ty::Infer(_)
-            | ty::Error(_) => MappingFlags::TO,
+            | ty::Param(_) => MappingFlags::TO,
 
             ty::RawPtr(_, Not) | ty::Ref(_, _, Not) => MappingFlags::TO,
 
@@ -109,6 +98,18 @@ impl MappingFlags {
             ty::Foreign(_) | ty::Pat(_, _) | ty::UnsafeBinder(_) => {
                 MappingFlags::TO | MappingFlags::FROM
             }
+
+            ty::FnDef(_, _)
+            | ty::FnPtr(_, _)
+            | ty::Closure(_, _)
+            | ty::CoroutineClosure(_, _)
+            | ty::Coroutine(_, _)
+            | ty::CoroutineWitness(_, _)
+            | ty::Never
+            | ty::Bound(_, _)
+            | ty::Placeholder(_)
+            | ty::Infer(_)
+            | ty::Error(_) => MappingFlags::TO, /* TODO(Sa4dUs): emit error */
         }
     }
 }