Some simplifications

Author: oli-obk

library/core/Cargo.toml

@@ -23,8 +23,6 @@ optimize_for_size = []
 # Make `RefCell` store additional debugging information, which is printed out when
 # a borrow error occurs
 debug_refcell = []
-# Make `TypeId` store a reference to the name of the type, so that it can print that name.
-debug_typeid = []
 
 [lints.rust.unexpected_cfgs]
 level = "warn"

library/core/src/any.rs

@@ -711,14 +711,23 @@ pub struct TypeId {
     /// Quick accept: if pointers are the same, the ids are the same
     data: &'static TypeIdData,
     /// Quick reject: if hashes are different, the ids are different
-    partial_hash: usize,
+    /// We use a raw pointer instead of a `usize`, because const eval
+    /// will be storing this as a fake pointer that will turn into the
+    /// appropriate bits at codegen time. This prevents users from inspecting
+    /// these bits at compile time.
+    partial_hash: *const (),
 }
 
+// SAFETY: the raw pointer is always an integer
+#[stable(feature = "rust1", since = "1.0.0")]
+unsafe impl Send for TypeId {}
+// SAFETY: the raw pointer is always an integer
+#[stable(feature = "rust1", since = "1.0.0")]
+unsafe impl Sync for TypeId {}
+
 #[derive(Clone, Copy, PartialEq, Eq, PartialOrd, Ord)]
 struct TypeIdData {
     full_hash: [u8; 16],
-    #[cfg(feature = "debug_typeid")]
-    name: &'static str,
 }
 
 #[stable(feature = "rust1", since = "1.0.0")]
@@ -759,15 +768,13 @@ impl TypeId {
     pub const fn of<T: ?Sized + 'static>() -> TypeId {
         let data = &const {
             let t: u128 = intrinsics::type_id::<T>();
-            TypeIdData {
-                full_hash: t.to_ne_bytes(),
-
-                #[cfg(feature = "debug_typeid")]
-                name: type_name::<T>(),
-            }
+            TypeIdData { full_hash: t.to_ne_bytes() }
         };
 
-        TypeId { data, partial_hash: intrinsics::type_id::<T>() as usize }
+        TypeId {
+            data,
+            partial_hash: crate::ptr::without_provenance(intrinsics::type_id::<T>() as usize),
+        }
     }
 
     fn as_u128(self) -> u128 {
@@ -803,15 +810,7 @@ impl hash::Hash for TypeId {
 #[stable(feature = "rust1", since = "1.0.0")]
 impl fmt::Debug for TypeId {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> Result<(), fmt::Error> {
-        #[cfg(feature = "debug_typeid")]
-        {
-            write!(f, "TypeId({:#034x} = {})", self.as_u128(), self.name)?;
-        }
-        #[cfg(not(feature = "debug_typeid"))]
-        {
-            write!(f, "TypeId({:#034x})", self.as_u128())?;
-        }
-        Ok(())
+        write!(f, "TypeId({:#034x})", self.as_u128())
     }
 }
 

library/coretests/tests/any.rs

@@ -118,14 +118,6 @@ fn any_unsized() {
     is_any::<[i32]>();
 }
 
-#[cfg(feature = "debug_typeid")]
-#[test]
-fn debug_typeid_includes_name() {
-    let type_id = TypeId::of::<[usize; 2]>();
-    let debug_str = format!("{type_id:?}");
-    assert!(debug_str.ends_with("= [usize; 2])"), "{debug_str:?} did not match");
-}
-
 #[test]
 fn distinct_type_names() {
     // https://github.com/rust-lang/rust/issues/84666

library/std/Cargo.toml

@@ -113,8 +113,6 @@ optimize_for_size = ["core/optimize_for_size", "alloc/optimize_for_size"]
 # Make `RefCell` store additional debugging information, which is printed out when
 # a borrow error occurs
 debug_refcell = ["core/debug_refcell"]
-# Make `TypeId` store a reference to the name of the type, so that it can print that name.
-debug_typeid = ["core/debug_typeid"]
 
 
 # Enable std_detect default features for stdarch/crates/std_detect:

library/sysroot/Cargo.toml

@@ -22,7 +22,6 @@ compiler-builtins-no-asm = ["std/compiler-builtins-no-asm"]
 compiler-builtins-no-f16-f128 = ["std/compiler-builtins-no-f16-f128"]
 compiler-builtins-mangled-names = ["std/compiler-builtins-mangled-names"]
 debug_refcell = ["std/debug_refcell"]
-debug_typeid = ["std/debug_typeid"]
 llvm-libunwind = ["std/llvm-libunwind"]
 system-llvm-libunwind = ["std/system-llvm-libunwind"]
 optimize_for_size = ["std/optimize_for_size"]