PR Feedback; remove crate name from top line error message

Author: Jamesbarford

src/librustdoc/core.rs

@@ -404,22 +404,14 @@ pub(crate) fn run_global_ctxt(
             crate::DOC_RUST_LANG_ORG_VERSION
         );
 
-        let krate_name = if let Some(name) = krate.module.inner.name {
-            format!("`{}`'s", name.as_str())
-        } else {
-            "this crate's".to_string()
-        };
         let span = tcx.def_span(krate.module.item_id.as_local_def_id().unwrap());
 
         tcx.node_lint(
             crate::lint::MISSING_CRATE_LEVEL_DOCS,
             DocContext::as_local_hir_id(tcx, krate.module.item_id).unwrap(),
             |lint| {
                 lint.span(span);
-                lint.primary_message(format!(
-                    "no documentation found for {} top-level module",
-                    krate_name
-                ));
+                lint.primary_message("no documentation found for this crate's top-level module");
                 lint.help(help);
             },
         );

tests/rustdoc-ui/lints/check.rs

@@ -1,7 +1,8 @@
 //@ check-pass
 //@ compile-flags: -Z unstable-options --check
 //@ normalize-stderr: "nightly|beta|1\.[0-9][0-9]\.[0-9]" -> "$$CHANNEL"
-#![feature(rustdoc_missing_doc_code_examples)] //~ WARN no documentation found for `check`'s top-level module
+
+#![feature(rustdoc_missing_doc_code_examples)] //~ WARN no documentation found for this crate's top-level module
 //~^ WARN
 
 #![warn(missing_docs)]
@@ -11,3 +12,4 @@
 pub fn foo() {}
 //~^ WARN
 //~^^ WARN
+

tests/rustdoc-ui/lints/check.stderr

@@ -1,5 +1,5 @@
 warning: missing documentation for the crate
-  --> $DIR/check.rs:4:1
+  --> $DIR/check.rs:5:1
    |
 LL | / #![feature(rustdoc_missing_doc_code_examples)]
 LL | |
@@ -10,19 +10,19 @@ LL | | pub fn foo() {}
    | |_______________^
    |
 note: the lint level is defined here
-  --> $DIR/check.rs:7:9
+  --> $DIR/check.rs:8:9
    |
 LL | #![warn(missing_docs)]
    |         ^^^^^^^^^^^^
 
 warning: missing documentation for a function
-  --> $DIR/check.rs:11:1
+  --> $DIR/check.rs:12:1
    |
 LL | pub fn foo() {}
    | ^^^^^^^^^^^^
 
-warning: no documentation found for `check`'s top-level module
-  --> $DIR/check.rs:4:1
+warning: no documentation found for this crate's top-level module
+  --> $DIR/check.rs:5:1
    |
 LL | / #![feature(rustdoc_missing_doc_code_examples)]
 LL | |
@@ -35,20 +35,20 @@ LL | | pub fn foo() {}
    = help: The following guide may be of use:
            https://doc.rust-lang.org/$CHANNEL/rustdoc/how-to-write-documentation.html
 note: the lint level is defined here
-  --> $DIR/check.rs:9:9
+  --> $DIR/check.rs:10:9
    |
 LL | #![warn(rustdoc::all)]
    |         ^^^^^^^^^^^^
    = note: `#[warn(rustdoc::missing_crate_level_docs)]` implied by `#[warn(rustdoc::all)]`
 
 warning: missing code example in this documentation
-  --> $DIR/check.rs:11:1
+  --> $DIR/check.rs:12:1
    |
 LL | pub fn foo() {}
    | ^^^^^^^^^^^^^^^
    |
 note: the lint level is defined here
-  --> $DIR/check.rs:8:9
+  --> $DIR/check.rs:9:9
    |
 LL | #![warn(rustdoc::missing_doc_code_examples)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

tests/rustdoc-ui/lints/no-crate-level-doc-lint.rs

@@ -1,5 +1,5 @@
 //@ normalize-stderr: "nightly|beta|1\.[0-9][0-9]\.[0-9]" -> "$$CHANNEL"
-#![deny(rustdoc::missing_crate_level_docs)] //~ ERROR no documentation found for `no_crate_level_doc_lint`'s top-level module
+#![deny(rustdoc::missing_crate_level_docs)] //~ ERROR no documentation found for this crate's top-level module
 //^~ NOTE defined here
 
 pub fn foo() {}

tests/rustdoc-ui/lints/no-crate-level-doc-lint.stderr

@@ -1,4 +1,4 @@
-error: no documentation found for `no_crate_level_doc_lint`'s top-level module
+error: no documentation found for this crate's top-level module
   --> $DIR/no-crate-level-doc-lint.rs:2:1
    |
 LL | / #![deny(rustdoc::missing_crate_level_docs)]