Change String in structs to &'a str

Author: SLASHLogin

compiler/rustc_codegen_llvm/src/errors.rs

@@ -2,9 +2,9 @@ use rustc_errors::fluent;
 use rustc_errors::DiagnosticBuilder;
 use rustc_session::SessionDiagnostic;
 
-pub(crate) enum UnknownCTargetFeature {
-    UnknownFeaturePrefix { feature: String },
-    UnknownFeature { feature: String, rust_feature: Option<String> },
+pub(crate) enum UnknownCTargetFeature<'a> {
+    UnknownFeaturePrefix { feature: &'a str },
+    UnknownFeature { feature: &'a str, rust_feature: Option<&'a str> },
 }
 
 impl SessionDiagnostic<'_, ()> for UnknownCTargetFeature {

compiler/rustc_codegen_llvm/src/llvm_util.rs

@@ -436,7 +436,7 @@ pub(crate) fn global_llvm_features(sess: &Session, diagnostics: bool) -> Vec<Str
                 Some(_) => {
                     if diagnostics {
                         sess.emit_warning(UnknownCTargetFeature::UnknownFeaturePrefix {
-                            feature: s.to_string(),
+                            feature: s,
                         });
                     }
                     return None;
@@ -455,8 +455,8 @@ pub(crate) fn global_llvm_features(sess: &Session, diagnostics: bool) -> Vec<Str
                     }
                 });
                 sess.emit_warning(UnknownCTargetFeature::UnknownFeature {
-                    feature: feature.to_string(),
-                    rust_feature: rust_feature.map(|f| f.to_string()),
+                    feature,
+                    rust_feature,
                 });
             }